Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ tasks:
task dbbootstraping
cd ..

#- init: ./spring-batch-projects/mvnw -B dependency:go-offline package -DskipTests
# command: java -jar target/*.jar
# name: Run SingleThreaded app

image:
file: .gitpod.Dockerfile

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# spring-batch-projects
# Spring Batch Plugin Lab

A monorepo for experimenting with Spring Batch: a dynamic plugin host service, four batch job plugins, and a Svelte ops UI.

Expand Down
4 changes: 2 additions & 2 deletions batch-job-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ mvn -f batch-job-api/pom.xml clean install

## Publishing

This artifact is published to **GitHub Packages** at `https://maven.pkg.github.com/fronzec/spring-batch-projects`.
This artifact is published to **GitHub Packages** at `https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab`.

### 1. GitHub Personal Access Token

Expand Down Expand Up @@ -55,7 +55,7 @@ Releases are immutable on GitHub Packages. Use `-SNAPSHOT` versions during devel
<repositories>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
</repositories>

Expand Down
4 changes: 2 additions & 2 deletions batch-job-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@
<distributionManagement>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
<snapshotRepository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</snapshotRepository>
</distributionManagement>
</project>
2 changes: 1 addition & 1 deletion fault-tolerant-harvester-job/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
<repositories>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
</repositories>
</project>
4 changes: 2 additions & 2 deletions fr-batch-service/Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ tasks:
- echo "db bootstraping finished"
dbschema:
cmds:
- mysql -p frbatchservicedb < /workspace/spring-batch-projects/fr-batch-service/_devenvironment/db/00_create_schema.sql
- mysql -p frbatchservicedb < /workspace/spring-batch-plugin-lab/fr-batch-service/_devenvironment/db/00_create_schema.sql
dbdata:
cmds:
- mysql -p frbatchservicedb < /workspace/spring-batch-projects/fr-batch-service/_devenvironment/db/01_init_data.sql
- mysql -p frbatchservicedb < /workspace/spring-batch-plugin-lab/fr-batch-service/_devenvironment/db/01_init_data.sql
Comment on lines +29 to +32

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Do not hardcode the workspace checkout path.

These commands only work when the repository is checked out exactly at /workspace/spring-batch-plugin-lab. The local setup documentation and scripts/seed-local-db.sh resolve the same SQL directory from the repository root, so use a root-derived or repository-relative path here as well.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@fr-batch-service/Taskfile.yml` around lines 29 - 32, The dbdata command in
Taskfile.yml hardcodes the repository checkout path. Update it to reference
01_init_data.sql through the repository-root or repository-relative SQL
directory, matching the path resolution used by the local setup documentation
and scripts/seed-local-db.sh.

prettier:
cmds:
# this is a basic config for prettier for java, see pom.xml for prettier-maven-plugin
Expand Down
2 changes: 1 addition & 1 deletion fr-batch-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<repositories>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
</repositories>

Expand Down
2 changes: 1 addition & 1 deletion partitioned-harvester-job/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
<repositories>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
</repositories>
</project>
2 changes: 1 addition & 1 deletion ticket-bundle-job/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
<repositories>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
</repositories>
</project>
2 changes: 1 addition & 1 deletion ticket-pdf-job/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
<repositories>
<repository>
<id>github</id>
<url>https://maven.pkg.github.com/fronzec/spring-batch-projects</url>
<url>https://maven.pkg.github.com/fronzec/spring-batch-plugin-lab</url>
</repository>
</repositories>
</project>
Loading