Skip to content

feat(plugins): serialize lifecycle transitions#87

Merged
fronzec merged 1 commit into
mainfrom
feat/plugin-lifecycle-integrity-pr-c-2
Jul 19, 2026
Merged

feat(plugins): serialize lifecycle transitions#87
fronzec merged 1 commit into
mainfrom
feat/plugin-lifecycle-integrity-pr-c-2

Conversation

@fronzec

@fronzec fronzec commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Closes #86

Summary

  • Serialize load, unload, and reload transitions per plugin definition.
  • Hold one lifecycle lock across reload unload and replacement load.
  • Preserve deterministic failure state and allow explicit recovery from FAILED.

Chain Context

main <- #85 lifecycle ownership <- #87 lifecycle transitions (current) 📍

This is PR 2 of 2. It starts from PR #85's registry ownership and reference-counted lifecycle holder, and ends with full lifecycle serialization, deterministic reload failure semantics, and verified ownership release.

Changes

File Change
DynamicJobLoaderService.java Serialize public lifecycle transitions and keep reload within one critical section.
DynamicJobLoaderServiceTest.java Cover lifecycle exclusion, reload failure semantics, ownership release, and FAILED recovery.

Test Plan

  • Focused: mvn -f fr-batch-service/pom.xml -Dtest=DynamicJobLoaderServiceTest,PluginRegistryServiceTest test - PASS, 40 tests, 0 failures/errors/skips.
  • Full module: mvn test -f fr-batch-service/pom.xml - PASS, 139 tests, 0 failures/errors/skips.
  • Package: mvn -f fr-batch-service/pom.xml -DskipTests package - BUILD SUCCESS.

Exclusions

  • DELETE safety and filesystem/database deletion coordination.
  • Multi-instance or distributed lifecycle locking.
  • Special repair APIs or a broad lifecycle transaction redesign.
  • The declined CodeRabbit holder-user timing nitpick.
  • The base-only initial LOADING persistence warning, unchanged from PR feat(plugins): consolidate lifecycle lock ownership #85.

Review Boundary

  • Review impact: 161 additions and 12 deletions across two files.
  • Rollback is limited to the loader service and its test in this PR.
  • No AI attribution or Co-Authored-By trailers.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@fronzec, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7cccf860-b5a9-429c-a816-517b5c971508

📥 Commits

Reviewing files that changed from the base of the PR and between a8e7a5a and b16310a.

📒 Files selected for processing (2)
  • fr-batch-service/src/main/java/com/fronzec/frbatchservice/batchjobs/plugins/loader/DynamicJobLoaderService.java
  • fr-batch-service/src/test/java/com/fronzec/frbatchservice/batchjobs/plugins/loader/DynamicJobLoaderServiceTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/plugin-lifecycle-integrity-pr-c-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

fronzec commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@fronzec
fronzec changed the base branch from feat/plugin-lifecycle-integrity-pr-c-1 to graphite-base/87 July 18, 2026 19:28
@fronzec
fronzec force-pushed the graphite-base/87 branch from b79178f to a8e7a5a Compare July 19, 2026 02:49
@fronzec
fronzec force-pushed the feat/plugin-lifecycle-integrity-pr-c-2 branch from 216748d to 18aa752 Compare July 19, 2026 02:49
@graphite-app
graphite-app Bot changed the base branch from graphite-base/87 to main July 19, 2026 02:49
@fronzec
fronzec force-pushed the feat/plugin-lifecycle-integrity-pr-c-2 branch from 18aa752 to b16310a Compare July 19, 2026 02:49

fronzec commented Jul 19, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 19, 3:13 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 19, 3:13 AM UTC: @fronzec merged this pull request with Graphite.

@fronzec
fronzec merged commit 92458e3 into main Jul 19, 2026
8 checks passed
@fronzec
fronzec deleted the feat/plugin-lifecycle-integrity-pr-c-2 branch July 19, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(plugin): serialize lifecycle transitions and preserve reload failure state

1 participant