Skip to content

[1/9] Update vendored SPUD to current upstream - #1

Open
friendly-ripper wants to merge 1 commit into
devfrom
stack/01-spud
Open

friendly-ripper wants to merge 1 commit into
devfrom
stack/01-spud

Conversation

@friendly-ripper

@friendly-ripper friendly-ripper commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Part 1 of 9 · base dev · 1 commit

The vendored SPUD snapshot is behind upstream, and its install call reports failure poorly. This PR replaces the snapshot with current upstream detour, relocation, and signature-scanning code so later hook work builds on the newer API.

What changes

  • The vendored copy under xmake-packages/packages/s/spud/spud-src/ is replaced. Upstream CMake manifests and the license file stay unchanged, so provenance can still be checked against upstream.
  • Callers and the x64 fixture move to the new install API. Install now reports failures instead of returning a bare pointer, which gives hook code a clear place to stop.
  • The chat title hooks go back to SetWidgetData and OnDidBindContext, on Windows too. The new SPUD patches fit the shared title wrapper, so neither the SetIdentifiers workaround nor the Windows skip is needed.

Testing

Built with xmake. The commit was built on macOS arm64. Nothing was run in the game.

Replace the vendored snapshot with the current upstream detour,
relocation and signature-scanning code. Callers and the x64
fixture move to the new install API, which reports failures
instead of returning a bare pointer.

The upstream CMake manifests and license stay unchanged, so
dependency provenance can still be checked directly.

The chat title hooks go back to SetWidgetData and OnDidBindContext,
on Windows too. The new SPUD patches fit the shared title wrapper,
so neither the SetIdentifiers workaround nor the Windows skip is
needed.
@friendly-ripper
friendly-ripper added this pull request to stack #9 October 18, 2026 16:31
@friendly-ripper friendly-ripper changed the title [1/8] Update SPUD to 394028e [1/8] Update SPUD to 04a9726 Oct 19, 2026
@friendly-ripper
friendly-ripper force-pushed the stack/01-spud branch 2 times, most recently from 0eadb68 to 08717dc Compare October 20, 2026 16:06
@friendly-ripper friendly-ripper changed the title [1/8] Update SPUD to 04a9726 [1/8] Update SPUD to d82f5a8 Oct 21, 2026
@friendly-ripper friendly-ripper changed the title [1/8] Update SPUD to d82f5a8 [1/8] Update SPUD to 7c3ea83 Oct 21, 2026
@friendly-ripper
friendly-ripper force-pushed the stack/01-spud branch 2 times, most recently from 6fc7c03 to 943d3fe Compare October 22, 2026 00:43
@friendly-ripper friendly-ripper changed the title [1/8] Update SPUD to 7c3ea83 [1/8] Update SPUD to e4d0c78 Oct 22, 2026
@friendly-ripper
friendly-ripper force-pushed the stack/01-spud branch 2 times, most recently from a44eccb to 115dd43 Compare October 24, 2026 23:26
@friendly-ripper friendly-ripper changed the title [1/8] Update SPUD to e4d0c78 [1/9] Update vendored SPUD to current upstream Oct 24, 2026
@friendly-ripper
friendly-ripper force-pushed the stack/01-spud branch 2 times, most recently from 5c7df28 to 9647c48 Compare October 28, 2026 18:15
@friendly-ripper
friendly-ripper force-pushed the stack/01-spud branch 2 times, most recently from 19a5c03 to 9582319 Compare November 13, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant