Fix code region validation#54
Open
Daniel1464 wants to merge 1 commit into
Open
Conversation
|
🌐 Preview URL: https://pr-54.frcsoftware.pages.dev |
samfreund
requested changes
Jun 29, 2026
|
|
||
| const START_RE = /^\s*(?:\/\/|#|--|<!--|-->)?\s*\[(\w+)\]\s*$/; | ||
| const END_RE = /^\s*(?:\/\/|#|--|<!--|-->)?\s*\[\/(\w+)\]\s*$/; | ||
| const CODEBLOCK_RE = /^```\w+\s+(\S+)#(\w+)/; |
Member
There was a problem hiding this comment.
Do you think it would be better to leave the exact match (^) at the start and add a zero or more white space match?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the codeblock region validation doesn't check if your codeblock is indented in some way (due to being located inside of a
<details>or<Aside>block). For instance, this wouldn't be recognized by the validation script:<Aside>
Lorem Ipsum....
```java stage0/JavaFundamentals.java#myCodeBlock
```
</Aside>
Because the triple backticks are indented by 2 spaces.