Skip to content

feat: regenerate client from corrected OpenAPI spec#3

Merged
mekilis merged 2 commits into
mainfrom
sdk-regen-spec-fixes
Jul 20, 2026
Merged

feat: regenerate client from corrected OpenAPI spec#3
mekilis merged 2 commits into
mainfrom
sdk-regen-spec-fixes

Conversation

@mekilis

@mekilis mekilis commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Local suite: 25/25 passing
  • Wide smoke against the QA harness passed

Note

Medium Risk
Large generated surface area and a breaking change to bulk onboard request typing; behavior shifts around null/optional JSON fields across many models.

Overview
Regenerates the Java client from the updated Convoy OpenAPI spec, with a post-generation perl step in generate.sh that fixes JsonNullable map helpers so put*Item does not NPE after setX(null) or JSON null.

Model changes are dominated by optional fields moving to JsonNullable (getters, *_JsonNullable setters, and nullable-aware equals/hashCode), plus EMPTY sentinel values on generated enums for open/null enum cases.

OnboardApi.bulkOnboard is a notable API break: the JSON body parameter is now ModelsBulkOnboardRequest (serialized as application/json) instead of a File with application/octet-stream.

Reviewed by Cursor Bugbot for commit cdccbe2. Bugbot is set up for automated code reviews on this repo. Configure here.

regenerated the java client from the spec produced by frain-dev/convoy#2742,
which fixes nullable object/map handling, the bearer auth security scheme,
json-only onboard, and portal link endpoints_metadata nullability.
Comment thread src/main/java/com/getconvoy/models/DatastoreEvent.java

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cdccbe2. Configure here.

Comment thread src/main/java/com/getconvoy/models/AuthRoleType.java
@mekilis
mekilis merged commit ca991ad into main Jul 20, 2026
3 checks passed
@mekilis
mekilis deleted the sdk-regen-spec-fixes branch July 20, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant