Modernize Docker installer and add CI tests - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker.sourcesformat anddocker.ascsigning keyWhy
The previous installer contained stale repository handling, incomplete package lists, ineffective options, unsafe non-interactive data-removal behavior, and documentation that no longer matched the implementation. The update makes destructive behavior explicit and aligns the installer with Docker's current Debian and Ubuntu instructions.
Impact
Users get a safer installer with predictable automation semantics, current repository configuration, clearer logs, and post-install verification of Docker Engine, Compose, Buildx, daemon access, and optional
hello-worldexecution.Validation
bash -n dockerinstall.sh tests/integration.sh tests/mock-command.shbash tests/integration.shgit diff --check origin/main...HEAD