Repository navigation
Stop showing readers the record's workflow status - #86
Merged
Merged
Conversation
Reported as the compounds page tagging everything "draft". It was: all 34 of them, in a monospace code element beside the evidence tier, on pages that are written, reviewed by a named pharmacist and indexed. `status` is internal state and nothing updates it. Every record has said 'draft' since it was drafted, which is why this looked like a bug about one directory and was actually the same stale field that had the homepage set to noindex and seven empty pages set to index. It leaked in four places, 226 times across 35 pages: the compounds directory, 34 labels the compare table on every compound page, which repeats it per row the no-reviewer notice, which named the status in the sentence 86 changelog entries ending "Status researched -> draft." All four now report something a reader can use. The directory and the compare table say when the record was reviewed, or "not yet" where no reviewer has signed it, which is the question the column was standing in for. The notice says the same thing in words. The changelog entries keep what changed and drop the state transition, which described the pipeline rather than the page. The about page computed a count of records at status 'published', always zero, and never rendered it. Removed. check_links.py gains a rule: no page may print any of the seven status values in a code element. That is narrow on purpose, so a paper titled "a draft genome" cannot trip it. Verified by injecting a leak, which exits 1. Visible occurrences of the word across the built site: 226 before, 0 after. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported as the compounds page tagging everything "draft". It was: all 34 of them, in a monospace
<code>element beside the evidence tier, on pages that are written, reviewed by a named pharmacist and indexed.Why
statusis internal workflow state and nothing updates it. Every record has saiddraftsince the day it was drafted. This looked like a bug about one directory; it is the same stale field that had the homepage set tonoindexand seven empty pages set toindex.Where it leaked
226 visible occurrences across 35 pages.
What readers see now
The directory and the compare table report when the record was reviewed, or "not yet" where nobody has signed it, which is the question that column was standing in for.
The changelog entries keep what changed and drop the state transition, which described the pipeline rather than the page. The about page computed a count of records at status
published, always zero, and never rendered it; removed.Four compounds correctly show "not yet reviewed": sermorelin, semaglutide, tirzepatide and bremelanotide. Those are the ones still unwritten.
A rule so it cannot come back
check_links.pygains a sixth rule: no page may print any of the seven status values inside a<code>element. Deliberately narrow, so a paper titled "a draft genome" cannot trip it. Verified by injecting a leak, which exits 1.Gates
Content validation (59 records), registry check, 36 drafter tests, 17 calculator tests, loop gate 47/47, all six link rules.
🤖 Generated with Claude Code