Skip to content

fix(sdk): track Ledger v2 release/v2.4 source - #2017

Merged
Dav-14 merged 1 commit into
mainfrom
codex/sdk-ledger-v2-release-v2.4
Nov 5, 2026
Merged

Dav-14 merged 1 commit into
mainfrom
codex/sdk-ledger-v2-release-v2.4

Conversation

@Dav-14

@Dav-14 Dav-14 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

- Ledger v2 OpenAPI: v2.4.17 release asset
+ Ledger v2 OpenAPI: release/v2.4 branch source

Fetch openapi.yaml through the GitHub contents API and refresh the Speakeasy source digests. SDK composition now follows fixes on the Ledger 2.4 branch.

Evidence

  • Before: LEDGER_V2_VERSION was pinned to v2.4.17 and downloaded a release asset.
    After: release/v2.4 resolves and its OpenAPI document downloads successfully through the configured contents endpoint.
  • Passed nix develop --impure --command just pre-commit: OpenAPI composition, all validate-openapi invariants, and event schema generation. Speakeasy reported 0 errors and 63 warnings; its local self-update emitted a cross-device rename diagnostic without failing validation.
  • Passed git diff --check; working tree clean after commit.
  • Generated downstream SDKs were not built or published.

Merge Danger

Door: two-way

Revert this commit to restore the release tag and downloader.

Blast Radius: SDK

Future generation follows a mutable release branch rather than an immutable tag. No runtime service configuration changes. No intentional API/data breaking changes or capability reductions; downstream SDK compatibility has not been separately qualified.

@NumaryBot NumaryBot added risk: medium NumaryBot classified this pull request as medium risk. bot-reviewed NumaryBot completed its review workflow for the current head. draft-reviewed NumaryBot reviewed this draft, but published no readiness signal. labels Nov 5, 2026
@Dav-14
Dav-14 marked this pull request as ready for review November 5, 2026 13:43
@NumaryBot NumaryBot added review-approved The NumaryBot review gate is satisfied for the current head. and removed draft-reviewed NumaryBot reviewed this draft, but published no readiness signal. labels Nov 5, 2026

@NumaryBot NumaryBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required automated review completed with no remaining findings.

@Dav-14
Dav-14 merged commit 2615a18 into main Nov 5, 2026
3 checks passed
@Dav-14
Dav-14 deleted the codex/sdk-ledger-v2-release-v2.4 branch November 5, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-reviewed NumaryBot completed its review workflow for the current head. review-approved The NumaryBot review gate is satisfied for the current head. risk: medium NumaryBot classified this pull request as medium risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants