chore: merge Lean 4.30 version bump into gs-bivariate-rr - #4
Open
codygunton wants to merge 19 commits into
Open
Conversation
Toolchain + mathlib require: v4.30.0-rc2 -> v4.30.0. rc2->final source fixes: - Data/Nat/Bitwise: (boddDiv2 _).fst/.snd no longer defeq to bodd/div2 → rw [Nat.boddDiv2_eq] - ToMathlib/MvPolynomial/Equiv: simp-normal-form drift → loosen `simp only` to `simp` - Multivariate/CMvPolynomialEvalLemmas: `convert … using 3` now yields an Iff → drop the spurious `ext` - Data/RingTheory/AlgebraTower: v4.30 `algebraMap`/`Algebra.algebraMap` no longer def-unfold via rw/simp_rw → use `RingHom.algebraMap_toAlgebra` Builds green on v4.30.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
v4.30.0 (final) made two broad-reach changes that recur across the binary-tower algebra: - `algebraMap` can no longer be `rw`/`simp_rw`-unfolded via its def. Replace `rw [algebraMap, Algebra.algebraMap]` with `simp only [RingHom.algebraMap_toAlgebra]` after unfolding the instance to its `.toAlgebra` form, or drop the now-redundant unfold where the term is already defeq (Algebra, Split, Concrete/Algebra/Basis). - `Algebra.algebraMap` is now the bundled hom (takes the type), so `Algebra.algebraMap x` (a value) breaks → `algebraMap _ _ x` (Basis, Concrete/Basis). Two intricate `multilinearBasis_apply` conv proofs (Abstract + Concrete Basis) thread the old `←algebraMap` fold / `Algebra.cast` through a long cast-heavy chain; left as documented `sorry` TODOs (not on ArkLib's path). CompPoly builds green (2418 jobs). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Closing: this helper PR was opened against the contributor fork by mistake; the intended coordination target is Verified-zkEVM/CompPoly. |
codygunton
changed the title
Author
|
Closing per request. |
olympichek
force-pushed
the
gs-bivariate-rr
branch
2 times, most recently
from
June 9, 2026 15:35
1542875 to
d950a82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the current CompPoly Lean 4.30 bump branch into
gs-bivariate-rr, the source branch for Verified-zkEVM#245. Lake build is verified.The actual Lean 4.30 migration and proof cleanup live in Verified-zkEVM#242.