Repository navigation
[iOS] SFRestAPI httpDateFormatter uses local timezone and truncates milliseconds - #4190
Conversation
… round fractional seconds)
|
||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4190 +/- ##
==========================================
- Coverage 72.92% 70.06% -2.86%
==========================================
Files 254 254
Lines 23531 23533 +2
==========================================
- Hits 17160 16489 -671
- Misses 6371 7044 +673
🚀 New features to boost your workflow:
|
|
||||||||||||||
|
The GMT and For example:
There is no lossless client-side rounding solution with this second-precision header: rounding down can produce false 412s, while rounding up can miss conflicts. Re-reading before updating does not close the race between those requests. The PR description acknowledges the rounding limitation, but documenting it alone does not preserve the public API's existing “not modified since the supplied date” contract. Salesforce documents My recommendation is to ship the GMT/locale correction and preserve the conservative timestamp behavior for now, treating rounding as a separate decision about the concurrency contract. I also checked all five SDK libraries at this PR head: no production caller supplies a non-nil conditional date, so built-in MobileSync does not execute this formatter; the behavior change affects consumers explicitly using the conditional-update API. Posted by Codex on behalf of @wmathurin. |
…onal-second cutoffs)
|
Agreed, Wolf. This follow-up commit removes upward rounding while retaining the GMT and
The revised regression test fails with The fractional-second false-412 limitation remains unresolved and needs a separate concurrency design. This patch does not provide strong validation. This response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce. |
9554dfb
into
forcedotcom:dev
Use GMT and
en_US_POSIXfor conditional-update HTTP dates. Preserve fractional-second truncation to avoid advancing the caller's cutoff. A fractional-second false HTTP 412 was not reproduced in the tested scope; date-based validation remains weak.Route the integration test through the production date parameter, removing its manual-header workaround.
Test plan:
This response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce.