feat: add invoice pdf download on purchase lists by tomrndom · Pull Request #1022 · fntechgit/summit-admin

tomrndom · 2026-07-24T21:19:11Z

ref: https://app.clickup.com/t/9014802374/86bb31qvd
depends on OpenStackweb/openstack-uicore-foundation#282 (comment)
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

New Features
- Added invoice PDF download actions for sponsor purchases.
- Invoices include summit-specific details and branding.
- Improved accessibility with translated download labels.
Bug Fixes
- Enhanced sponsor order retrieval to support selecting the correct sponsor context.
- Prevents concurrent invoice generation/download requests.
- Displays user-facing errors when invoice generation fails.
Chores / Tests
- Updated UI core dependency and adjusted Jest file mock mapping.
- Improved test mocks and added summit context to test state.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

coderabbitai · 2026-07-24T21:19:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a73282c1-8ff0-41ec-9eed-dee8386a0918

📥 Commits

Reviewing files that changed from the base of the PR and between 2af4f37 and c8f9285.

📒 Files selected for processing (2)

src/pages/sponsors/show-purchase-list-page/index.js
src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js

🚧 Files skipped from review as they are similar to previous changes (2)

src/pages/sponsors/show-purchase-list-page/index.js
src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js

📝 Walkthrough

Walkthrough

Sponsor purchase views now support invoice PDF downloads. They retrieve sponsor orders with optional sponsor identifiers, generate PDFs using summit data, prevent duplicate requests, display translated errors, and expose accessible download actions.

Changes

Sponsor invoice downloads

Layer / File(s)	Summary
Sponsor order lookup contract `src/actions/sponsor-purchases-actions.js`	`getSponsorOrder` accepts an optional `sponsorId` and uses the resolved identifier in the purchase-order API endpoint.
Purchase list invoice flow `src/pages/sponsors/show-purchase-list-page/index.js`, `src/i18n/en.json`	The purchase list fetches orders and generates invoice PDFs using summit data and a logo, with loading protection, translated errors, and an accessible download action.
Sponsor purchases tab invoice flow `src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/index.js`, `src/pages/sponsors/sponsor-page/tabs/sponsor-purchases-tab/__tests__/*`, `package.json`	The sponsor purchases tab adds guarded invoice generation, summit-state wiring, translated errors, accessible download behavior, test state and mocks, and supporting Jest/dependency configuration.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SponsorPurchaseView
  participant getSponsorOrder
  participant generateInvoicePDF
  SponsorPurchaseView->>getSponsorOrder: Fetch selected sponsor order
  getSponsorOrder-->>SponsorPurchaseView: Return order data
  SponsorPurchaseView->>generateInvoicePDF: Generate invoice with summit data and logo
  generateInvoicePDF-->>SponsorPurchaseView: Download invoice PDF

Possibly related PRs

fntechgit/summit-admin#757: Extends the sponsor purchases tab and overlaps its invoice-download implementation.
fntechgit/summit-admin#961: Reuses getSponsorOrder in a related sponsor-order refresh flow.
fntechgit/summit-admin#1021: Implements the same invoice PDF and sponsor-order wiring.

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding invoice PDF download support on purchase lists.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/invoice-purchases-pdf

_{Comment @coderabbitai help to get the list of available commands.}

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

smarcet · 2026-07-27T21:39:56Z

+    setLoadingPDF(true);
+    getSponsorOrder(item.id, sponsor.id)
+      .then(({ response: fetchedOrder }) =>
+        generateInvoicePDF(fetchedOrder, currentSummit, {


@tomrndom generateInvoicePDF is called with the raw, un-normalized order fetched here, but the rest of this app normalizes this exact order shape before rendering it — the PDF will disagree with the on-screen grid on discount line descriptions.

{ response: fetchedOrder } is the raw API response from getSponsorOrder. Everywhere else this order shape reaches the UI (SponsorOrderGrid on SponsorOrderDetails), it goes through normalizeOrder() (src/pages/sponsors/sponsor-page/utils.js:6-13) first, via the RECEIVE_SPONSOR_ORDER reducer (sponsor-page-purchase-list-reducer.js:101). openstack-uicore-foundation's OrderPdf/buildRows (which generateInvoicePDF renders) expects form.discount to already be the formatted string normalizeOrder produces (formatDiscount(form.discount_amount, form.discount_type)) — its own test fixtures pass discount: "15%" as a literal. Passing the raw order here means form.discount is undefined on every form, so any order with a discount applied downloads a PDF where the "DIS" line shows the right amount but a blank description.

Same pattern at src/pages/sponsors/show-purchase-list-page/index.js:99-106.

Suggested fix: run fetchedOrder through normalizeOrder() before calling generateInvoicePDF, the same way the reducer does for the on-screen view — generateInvoicePDF(normalizeOrder(fetchedOrder), currentSummit, {...}). (Flagged the same gap from the uicore side on OpenStackweb/openstack-uicore-foundation#282, since either OrderPdf enforcing/documenting its expected shape or normalizing here before the call closes it.)

smarcet · 2026-07-27T21:40:09Z

+    setLoadingPDF(true);
+    getSponsorOrder(purchaseOrder.id, purchaseOrder.sponsor_id)
+      .then(({ response: fetchedOrder }) =>
+        generateInvoicePDF(fetchedOrder, currentSummit, {


@tomrndom Same raw-vs-normalized order gap as sponsor-purchases-tab/index.js:97 — fetchedOrder here is never passed through normalizeOrder() before generateInvoicePDF, so discount line descriptions will be blank in the downloaded PDF for this entry point too. Same fix: generateInvoicePDF(normalizeOrder(fetchedOrder), currentSummit, {...}).

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

smarcet

@tomrndom please review

…oice PDF Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

tomrndom added 2 commits July 24, 2026 17:18

feat: add invoice pdf download on purchase lists

3aeb075

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: adjust aria labels, actions params

202cea9

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

fix: adjust test mocks and fileMock directory

2af4f37

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

smarcet reviewed Jul 27, 2026

View reviewed changes

smarcet requested a review from Copilot July 27, 2026 21:40

Copilot AI reviewed Jul 27, 2026

smarcet requested changes Jul 27, 2026

View reviewed changes

fix: add normalize function on API order response before generate inv…

c8f9285

…oice PDF Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add invoice pdf download on purchase lists - #1022

feat: add invoice pdf download on purchase lists#1022
tomrndom wants to merge 4 commits into
masterfrom
feature/invoice-purchases-pdf

tomrndom commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

smarcet Jul 27, 2026

Uh oh!

smarcet Jul 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

smarcet left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tomrndom commented Jul 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

smarcet Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

smarcet Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

smarcet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tomrndom commented Jul 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading