Build nolocale-test with /utf-8 on MSVC - #4919
Merged
Merged
Conversation
vitaut
requested changes
Sep 6, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. The fix makes sense but please address the inline comment.
Comment on lines
135
to
136
| target_compile_definitions(nolocale-test | ||
| PRIVATE FMT_STATIC_THOUSANDS_SEPARATOR=1) |
Contributor
There was a problem hiding this comment.
Let's add $<$<CXX_COMPILER_ID:MSVC>:/utf-8> here instead.
Contributor
Author
There was a problem hiding this comment.
Done, switched to $<$<CXX_COMPILER_ID:MSVC>:/utf-8>.
Rebuilt on MSVC 17 2022 with -DFMT_PEDANTIC=ON -DFMT_TEST=ON -DCMAKE_CXX_STANDARD=20: nolocale-test compiles, the full build has no errors, and ctest is 23/23. Reverting just this hunk still fails with error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8' at base.h:455.
nolocale-test compiles src/format.cc directly, so it does not pick up the /utf-8 that CMakeLists.txt adds to the fmt target. On MSVC the static_assert in base.h then fires: "Unicode support requires compiling with /utf-8". The target only exists under FMT_PEDANTIC, which the Windows workflow does not set, so this has not shown up in CI. unicode-test already guards the same flag the same way.
ethanstoner
force-pushed
the
fix/nolocale-test-utf8-msvc
branch
from
September 6, 2026 19:42
2bc1443 to
3a241dd
Compare
vitaut
approved these changes
Sep 6, 2026
Contributor
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nolocale-testdoes not compile with MSVC whenFMT_PEDANTICis on:The target is built from
../src/format.ccdirectly (test/CMakeLists.txt:132), so it does not pick up the/utf-8thatCMakeLists.txt:255adds to thefmttarget.unicode-testalready guards the same flag the same way attest/CMakeLists.txt:73-75, so this follows that.It has not shown up in CI because the target only exists under
FMT_PEDANTIC, andwindows.ymldoes not set it, whilelinux.yml:211-212andmacos.yml:46both do.Checked at C++20 and C++23 with MSVC 19.44, since I wondered whether it was standard-specific. It is not, it fails at both. After the change the full build succeeds and
ctestis 23/23 withFMT_PEDANTIC=ON.Disclosure: written with AI assistance. The build output above is from my own machine.