Fix exception formatters with exceptions disabled - #4904
Merged
Conversation
cjacek
force-pushed
the
no-exceptions
branch
2 times, most recently
from
September 4, 2026 16:22
dca523d to
f1c4546
Compare
vitaut
requested changes
Sep 4, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, but I don’t think we should disable the std::exception formatter itself. Instead, please disable only the minimal part that relies on try/catch. Also, could you post the full compiler error message?
cjacek
force-pushed
the
no-exceptions
branch
from
September 4, 2026 17:10
f1c4546 to
af6e646
Compare
Contributor
Author
|
Thanks for the review. The new version disables only minimal part of The error message is: Here is a compiler explorer repro: https://godbolt.org/z/7jKncahEK It's specific to usage in templates that's now allowed. Outside templates it's always an error. |
vitaut
requested changes
Sep 5, 2026
…tions are disabled. Fixes building with Clang 20 and older with -fno-exceptions, which treats try/catch usage as an error.
cjacek
force-pushed
the
no-exceptions
branch
from
September 6, 2026 20:23
af6e646 to
6d956be
Compare
vitaut
changed the title
vitaut
approved these changes
Sep 7, 2026
Contributor
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes building with Clang 20 and older with -fno-exceptions, which treats try/catch usage as an error.
Fixes FEX builds: FEX-Emu/FEX#5870