Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ def _convert_replica_spec(

def _convert_run_policy(self, run_policy: RunPolicy) -> kubeflow_common.RunPolicy:
return kubeflow_common.RunPolicy(
clean_pod_policy=run_policy.clean_pod_policy.value if run_policy.clean_pod_policy.value else None,
clean_pod_policy=run_policy.clean_pod_policy.value
if run_policy.clean_pod_policy and run_policy.clean_pod_policy.value
else None,
ttl_seconds_after_finished=run_policy.ttl_seconds_after_finished,
active_deadline_seconds=run_policy.active_deadline_seconds,
backoff_limit=run_policy.backoff_limit,
Expand Down
17 changes: 17 additions & 0 deletions plugins/flytekit-kf-tensorflow/tests/test_tensorflow_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,3 +254,20 @@ def my_tensorflow_task(x: int, y: str) -> int:
assert my_tensorflow_task.resources.limits == Resources()
assert my_tensorflow_task.resources.requests == Resources(cpu="1")
assert my_tensorflow_task.task_type == "tensorflow"


def test_tensorflow_task_run_policy_without_clean_pod_policy(serialization_settings: SerializationSettings):
task_config = TfJob(
worker=Worker(replicas=1),
ps=PS(replicas=0),
chief=Chief(replicas=0),
evaluator=Evaluator(replicas=0),
run_policy=RunPolicy(ttl_seconds_after_finished=100),
)

@task(task_config=task_config, requests=Resources(cpu="1"))
def my_tensorflow_task(x: int) -> int:
return x

custom = my_tensorflow_task.get_custom(serialization_settings)
assert custom["runPolicy"] == {"ttlSecondsAfterFinished": 100}