Skip to content

runtime: Migrate to new Kubernentes event API - #1144

Open
adri1197 wants to merge 1 commit into
fluxcd:mainfrom
adri1197:event-api
Open

runtime: Migrate to new Kubernentes event API#1144
adri1197 wants to merge 1 commit into
fluxcd:mainfrom
adri1197:event-api

Conversation

@adri1197

@adri1197 adri1197 commented Mar 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Event Recorder implementation to fully support the Kubernetes Events API events.k8s.io/v1 (replacing k8s.io/client-go/tools/record to k8s.io/client-go/tools/events module). The recorder implements the events.EventRecorder interface, enabling compatibility with modern Kubernetes event handling while maintaining backward compatibility for existing webhook-based notifications.

Closes fluxcd/flux2#5761

@stefanprodan stefanprodan added the area/runtime Controller runtime related issues and pull requests label Mar 8, 2026
@stefanprodan stefanprodan changed the title Migrate to new Kubernentes event API runtime: Migrate to new Kubernentes event API Mar 8, 2026
@matheuscscp

matheuscscp commented Mar 8, 2026

Copy link
Copy Markdown
Member

What's the minimum k8s version for this to work?

matheuscscp
matheuscscp reviewed Mar 8, 2026
View reviewed changes

@matheuscscp matheuscscp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lib should support related and let callers decide whether or not to use it

Comment thread runtime/events/recorder.go
Comment thread runtime/events/recorder.go Outdated
Comment thread runtime/events/recorder.go Outdated
Comment thread runtime/events/recorder.go Outdated
@matheuscscp

matheuscscp commented Mar 8, 2026

Copy link
Copy Markdown
Member

The lib should support related and let callers decide whether or not to use it

We should also add related as a constant in fluxcd/pkg/apis/event and send the related object reference under this field to notification-controller

@adri1197

adri1197 commented Mar 9, 2026

Copy link
Copy Markdown
Author

What's the minimum k8s version for this to work?

Looks like it became GA in 1.19 - KEP-383

stefanprodan
stefanprodan reviewed Mar 9, 2026
View reviewed changes

@stefanprodan stefanprodan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo all changes to events/v1beta1 and add events/v1.

Also go.mod changes are unrelated, please undo.

@adri1197

adri1197 commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Shall the naming conventions be aligned, events/v1 with the upstream k8s.io/api/events/v1 (Event type)? On top of the new field additions, I’ve noticed that several ones have been renamed (e.g., InvolvedObject becoming Regarding).

Table (KEP-383)

image

stefanprodan
stefanprodan reviewed Mar 10, 2026
View reviewed changes
Comment thread apis/event/v1/action.go Outdated
@adri1197
adri1197 force-pushed the event-api branch 2 times, most recently from 70e41ea to 7532591 Compare March 10, 2026 10:11
stefanprodan
stefanprodan reviewed Mar 10, 2026
View reviewed changes
Comment thread apis/event/v1/event.go Outdated
@adri1197
adri1197 force-pushed the event-api branch 2 times, most recently from 7ebb1d7 to d51ad46 Compare March 11, 2026 12:00
@adri1197 adri1197 mentioned this pull request Mar 11, 2026
Open
15 tasks
@adri1197 adri1197 mentioned this pull request Jun 5, 2026
Draft
@adri1197
adri1197 force-pushed the event-api branch 2 times, most recently from 141e229 to 7f5628b Compare June 24, 2026 13:45
@adri1197
adri1197 marked this pull request as ready for review August 27, 2026 16:49
@adri1197
adri1197 requested a review from a team as a code owner August 27, 2026 16:49
adri1197
adri1197 commented Aug 27, 2026
View reviewed changes
Comment thread runtime/go.mod

require (
github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6
github.com/fluxcd/cli-utils v1.2.2

@adri1197 adri1197 Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a dependency with controller-runtime, which downgrades cli-utils to github.com/fluxcd/cli-utils v1.2.0. Shall it be upgraded there first? - fluxcd/cli-utils#38

@adri1197
adri1197 requested a review from matheuscscp August 27, 2026 16:51
matheuscscp
matheuscscp reviewed Aug 27, 2026
View reviewed changes
Comment thread apis/event/v1/action.go
matheuscscp
matheuscscp reviewed Aug 27, 2026
View reviewed changes
Comment thread runtime/events/recorder.go Outdated
@adri1197
Migrate event recorder to events/v1 API
a63ed5f 
Add apis/event/v1 typed schema and update the runtime events
recorder to emit eventsv1.Event objects instead of the legacy
corev1.Event type. Introduce a FakeRecorder for testing and a
GetEvents helper in runtime/testenv for asserting on emitted
events in integration tests.

Signed-off-by: Adrian Fernandez De La Torre <adri1197@gmail.com>
@adri1197
adri1197 requested a review from matheuscscp August 28, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanprodan stefanprodan stefanprodan left review comments
@matheuscscp matheuscscp Awaiting requested review from matheuscscp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/runtime Controller runtime related issues and pull requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Kubernetes Event API v1

3 participants

@adri1197 @matheuscscp @stefanprodan