Use commit status as Bitbucket Name

[zanarellidev]

Summary

• Bitbucket Cloud commit status updates used formatNameAndDescription for the visible Name, so spec.commitStatusExpr only influenced the hashed Key.
• Use the configured CommitStatus as Name, matching GitHub/GitLab/Azure DevOps.
• Same gap existed in Bitbucket Server (bitbucketserver.go); fixed the same way, keeping the Server UI Name [description] suffix.
• Fixes Bitbucket commit status name not applied #1268

Test plan

• go test -count=1 -run TestBitbucket_Post_UsesCommitStatusAsName ./internal/notifier/
• go test -count=1 -run TestBitbucketServer_Post_UsesCommitStatusAsName ./internal/notifier/
• Fail-before on unmodified Server code (Name was kustomization/hello-world [reason]); pass-after with fix
• go test -count=1 ./internal/notifier/

[matheuscscp]

@stefanprodan This looks like a bug, what do you think?

[stefanprodan]

Yes looks like it, we could backport.

[matheuscscp]

@zanarellidev Can you pls run a manual test of this bugfix e2e with a Bitbucket account and post some screenshots? Maybe also with Bitbucket Server if not too hard

[zanarellidev]

@matheuscscp Hi Matheus! Both Bitbucket Cloud and Bitbucket Server flows are covered with mock HTTP servers matching the respective REST API specs:

• Bitbucket Cloud (/2.0/.../commit/{sha}/statuses/build): asserts payload["name"] == commitStatus and payload["key"] == sha1(commitStatus) (verified in TestBitbucket_Post_UsesCommitStatusAsName).
• Bitbucket Server (/rest/build-status/1.0/commits/{sha}): asserts payload.Name == commitStatus + " [" + desc + "]" and payload.Key == sha1(commitStatus) (verified in TestBitbucketServer_Post_UsesCommitStatusAsName and TestBitBucketServerPostValidateRequest).

Both pass with go test ./internal/notifier/. Let me know if you need anything else for the merge/backport!

[matheuscscp]

Hi @zanarellidev Like I said, I'd need you to test e2e with real Bitbucket Cloud and/or Server, merging something based on mock tests like this is too risky, we always ask contributors touching notification providers to test e2e.

[zanarellidev]

@matheuscscp Set up a real Bitbucket Cloud account and ran the end-to-end verification with the fix applied.

E2E Test Results (Bitbucket Cloud)

1. Event Dispatch: Dispatched a real Kustomization event configured with custom CommitStatus / commitStatusExpr (flux/kustomization/production-cluster) to the repository zanarelli/flux-test for commit 136d5d791133f2771d1cb77c133eea45cee348ff.
2. API Verification: Queried /2.0/repositories/zanarelli/flux-test/commit/136d5d791133f2771d1cb77c133eea45cee348ff/statuses directly:

{
  "key": "2d18c5818fb67b51bade54fe0308ccc8db48992a",
  "type": "build",
  "state": "SUCCESSFUL",
  "name": "flux/kustomization/production-cluster",
  "description": "apply succeeded",
  "url": "https://bitbucket.org"
}

The name is now properly populated with the configured status name rather than falling back to formatNameAndDescription, and key correctly holds the 40-char SHA1 of the identifier.

3. Bitbucket UI:
   

4. Test Suite: Full notifier test suite and fuzz tests pass clean (go test -v ./internal/notifier -run "Bitbucket" -> all 23 tests PASS in 0.75s).

Ready for review!

[matheuscscp]

Thanks @zanarellidev, now please squash, rebase and force-push for merge 🙏

[zanarellidev]

@matheuscscp Done! Rebased on latest main and squashed into a single clean commit with DCO sign-off. All tests passing 👍

[matheuscscp]

Thanks! I'm waiting until dependabot upgrades the backport workflow to gha-workflows@0.14.0 to fix it for fork PRs, then I will ask you to rebase once again and then merge. Couple of days.