Repository navigation
fix(web): prevent race conditions in concurrent wake lock requests - #152
Open
FaizanUllahDev wants to merge 8 commits into
Open
FaizanUllahDev wants to merge 8 commits into
FaizanUllahDev wants to merge 8 commits into
Conversation
diegotori
requested changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #150.
Problem
Concurrent
enable()calls could trigger multiple wake-lock requests while sharing the same promise completer. When one request completed and cleared the shared reference, another callback could throw an unhandledTypeError.The video fallback implementation had a similar concurrency issue.
Changes
Testing
Modified Files
wakelock_plus/lib/assets/no_sleep.jswakelock_plus/test/no_sleep_concurrency.test.cjs.github/workflows/checks.ymlScope
Changes are limited to the web implementation, regression tests, and CI configuration. Native Android, iOS, macOS, Windows, and Linux implementations remain unchanged.