Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,12 +1,58 @@
import Flutter
import LinkPresentation
import UIKit
import XCTest

class RunnerTests: XCTestCase {

func testExample() {
// If you add code to the Runner application, consider adding tests here.
// See https://developer.apple.com/documentation/xctest for more information about using XCTest.
@MainActor
func testLinkPayloadRemainsAURL() throws {
let item = try makeLinkItem(title: "Product title", subject: "Email subject")
let controller = UIActivityViewController(activityItems: [item], applicationActivities: nil)
XCTAssertEqual(item.activityViewControllerPlaceholderItem(controller) as? URL, link)
for activity in [UIActivity.ActivityType.mail, .copyToPasteboard, nil] {
XCTAssertEqual(
item.activityViewController(controller, itemForActivityType: activity) as? URL, link)
}
}

@MainActor
func testLinkPreviewTitleAndEmailSubjectAreIndependent() throws {
let item = try makeLinkItem(title: "Product title", subject: "Email subject")
let controller = UIActivityViewController(activityItems: [item], applicationActivities: nil)
let metadata = try XCTUnwrap(item.activityViewControllerLinkMetadata?(controller))
XCTAssertEqual(metadata.title, "Product title")
XCTAssertEqual(metadata.url, link)
XCTAssertEqual(metadata.originalURL, link)
XCTAssertEqual(
item.activityViewController?(controller, subjectForActivityType: .mail), "Email subject")
}

@MainActor
func testLinkPreviewFallsBackToSubjectThenURL() throws {
let cases: [(String?, String?, String)] = [
(nil, "Email subject", "Email subject"),
("", "Email subject", "Email subject"),
(nil, nil, link.absoluteString),
("", "", link.absoluteString),
]
for (title, subject, expectedTitle) in cases {
let item = try makeLinkItem(title: title, subject: subject)
let controller = UIActivityViewController(activityItems: [item], applicationActivities: nil)
let metadata = try XCTUnwrap(item.activityViewControllerLinkMetadata?(controller))
XCTAssertEqual(metadata.title, expectedTitle)
XCTAssertEqual(
item.activityViewController?(controller, subjectForActivityType: .mail), subject)
}
}

private let link = URL(string: "https://example.com/product?id=123")!

private func makeLinkItem(title: String?, subject: String?) throws -> UIActivityItemSource {
let itemClass = try XCTUnwrap(NSClassFromString("SharePlusLinkData") as? NSObject.Type)
let item = itemClass.init()
item.setValue(link, forKey: "url")
item.setValue(title, forKey: "title")
item.setValue(subject, forKey: "subject")
return try XCTUnwrap(item as? UIActivityItemSource)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,43 @@ static void initializeActivityTypeMapping(void) {
return [result copy];
}

// Keep URL sharing typed while supplying metadata without a webpage fetch.
@interface SharePlusLinkData : NSObject <UIActivityItemSource>
@property(nonatomic, copy) NSURL *url;
@property(nonatomic, copy) NSString *title;
@property(nonatomic, copy) NSString *subject;
@end

@implementation SharePlusLinkData
- (id)activityViewControllerPlaceholderItem:
(UIActivityViewController *)activityViewController {
return self.url;
}

- (id)activityViewController:(UIActivityViewController *)activityViewController
itemForActivityType:(UIActivityType)activityType {
return self.url;
}

- (NSString *)activityViewController:
(UIActivityViewController *)activityViewController
subjectForActivityType:(UIActivityType)activityType {
return self.subject;
}

- (LPLinkMetadata *)activityViewControllerLinkMetadata:
(UIActivityViewController *)activityViewController {
LPLinkMetadata *metadata = [[LPLinkMetadata alloc] init];
metadata.originalURL = self.url;
metadata.URL = self.url;
metadata.title =
self.title.length > 0
? self.title
: (self.subject.length > 0 ? self.subject : self.url.absoluteString);
return metadata;
}
@end

@interface SharePlusData : NSObject <UIActivityItemSource>

@property(readonly, nonatomic, copy) NSString *subject;
Expand Down Expand Up @@ -363,6 +400,8 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {

if (uri) {
[self shareUri:uri
title:arguments[@"title"]
subject:arguments[@"subject"]
excludedActivityTypes:excludedActivityTypes
withController:topViewController
atSource:originRect
Expand Down Expand Up @@ -458,13 +497,18 @@ + (void)share:(NSArray *)shareItems
}

+ (void)shareUri:(NSString *)uri
title:(NSString *)title
subject:(NSString *)subject
excludedActivityTypes:(NSArray<UIActivityType> *)excludedActivityTypes
withController:(UIViewController *)controller
atSource:(CGRect)origin
toResult:(FlutterResult)result {
NSURL *data = [NSURL URLWithString:uri];
SharePlusLinkData *data = [[SharePlusLinkData alloc] init];
data.url = [NSURL URLWithString:uri];
data.title = title;
data.subject = subject;
[self share:@[ data ]
withSubject:nil
withSubject:subject
excludedActivityTypes:excludedActivityTypes
withController:controller
atSource:origin
Expand Down
Loading