feat(share_plus): preview a video frame in the share sheet on iOS - #3959
Open
gabdsg wants to merge 2 commits into
Open
feat(share_plus): preview a video frame in the share sheet on iOS#3959gabdsg wants to merge 2 commits into
gabdsg wants to merge 2 commits into
Conversation
Sharing a video shows a generic document icon where an image shows a preview. The preview is built with `imageWithContentsOfFile:`, which returns nil for a video, and both call sites are gated on a mime type starting with `image/` -- including the `imageProvider` on the link metadata, which is what draws the sheet's header. Extracts one `previewImage` helper both call sites use, and adds a `videoThumbnailForPath:` that pulls a frame with AVAssetImageGenerator. `appliesPreferredTrackTransform` is set so portrait footage is not previewed sideways, the frame is taken half a second in because frame zero is black on anything that fades in, and the +1 reference from `copyCGImageAtTime` is released. No Dart API change.
gabdsg
changed the title
Author
|
I see some tests are failing, but they don't appear to be related to the changes I made. |
Collaborator
|
Yeah, just ignore them. Will review at some point, but currently have a limited availability, so no hard promises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing a video shows a generic document icon where an image shows a preview. The preview is built with
imageWithContentsOfFile:, which returns nil for a video, and both call sites are gated on a mime type starting withimage/-- including theimageProvideron the link metadata, which is what draws the sheet's header.Extracts one
previewImagehelper both call sites use, and adds avideoThumbnailForPath:that pulls a frame with AVAssetImageGenerator.appliesPreferredTrackTransformis set so portrait footage is not previewed sideways, the frame is taken half a second in because frame zero is black on anything that fades in, and the +1 reference fromcopyCGImageAtTimeis released.No Dart API change.
Description
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).