[ios]update uiscene adoption#13560
Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit 95a5828): https://flutter-docs-prod--docs-pr13560-update-uiscene-doc-e5et10kn.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit 95a5828): https://flutter-dev-230821--www-pr13560-update-uiscene-doc-dd1n4tr6.web.app |
a0b98f2 to
06426ef
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
06426ef to
fdd6fd6
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for UIScene adoption in Flutter iOS apps, clarifying that multiple scenes are not yet fully supported and adding guidance on registering background tasks before app launch finishes. The review feedback identifies a compilation error in the Swift code snippet due to a typo in a parameter name, as well as an inconsistency between the text explanation and the code comments regarding which AppDelegate launch method should be used.
| > and they’re ready to use before HealthKit delivers the updates. | ||
|
|
||
| For example, to support `BGTaskScheduler`: | ||
| <Tabs key="ios-language-switcher"> |
There was a problem hiding this comment.
The tabs do not show. Something must be wrong with the spacing or something.
There was a problem hiding this comment.
Turns out that it needs an extra blank line
| </Tab> | ||
| </Tabs> | ||
|
|
||
| 1. Optional: Migrate other deprecated APIs to support |
There was a problem hiding this comment.
Can you remove the optional from this? Let's encourage people to do it
| 1. Optional: Migrate other deprecated APIs to support | |
| 1. Migrate other deprecated APIs to support |
There was a problem hiding this comment.
Maybe change to
"Migrate other deprecated APIs to properly access the viewController, screen, or window."
|
Hmmm It looks like I don't have merge permission. @Sfshaza if you can help take a look too that'd be great! Thank you! |
4 participants
This PR polishes UIScene adoption doc. Including:
performFetchWithCompletionHandlerIssues fixed by this PR (if any):
One of the issues fixed is:
Fixed flutter/flutter#186976
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.