Normalize changelogs - #12520
Conversation
semi-automated update to normalize CHANGELOG.md files to follow https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
There was a problem hiding this comment.
Code Review
This pull request normalizes the changelog entries across multiple packages to consistently use present-tense verbs and end with a period. It also updates the version and changelog validator tool to support a new override: allow changelog edit label, which permits direct edits to CHANGELOG.md files in packages that use batch releases, and adds a corresponding test. The review feedback highlights several grammatical errors and style guide inconsistencies introduced by the automated normalization, such as incorrect verb tenses, double periods, and awkward phrasing resulting from direct verb substitutions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This reverts commit 354fe87.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
packagesto follow https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style, i.e. present tense verbs, periods, and BREAKING CHANGE noticesgoogle_fontsgenerator to follow style guide (3f0ad2a)override: allow changelog editlabel) receive changelog updates (e.g. to fix past typos or fix style)To avoid churn, not bumping versions or releasing.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2