[cupertino_ui] Add rubber-band physics simulation to CupertinoSheet when enableDrag is false - #12516
Draft
xxxOVALxxx wants to merge 3 commits into
Draft
[cupertino_ui] Add rubber-band physics simulation to CupertinoSheet when enableDrag is false#12516xxxOVALxxx wants to merge 3 commits into
xxxOVALxxx wants to merge 3 commits into
Conversation
xxxOVALxxx
marked this pull request as draft
August 19, 2026 23:10
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a rubber-banding and spring-back animation for Cupertino sheets when dragging is disabled, using Apple's rubber-banding formula and a physical spring simulation. It also ensures that sheets ignore gestures mid-dismissal. Feedback suggests declaring the global _sheetSpring variable as final, optimizing the squaring calculation in _computeRubberBandFriction by replacing math.pow with direct multiplication, and checking navigator.mounted before calling navigator.didStopUserGesture() to prevent potential exceptions during the animation.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds native iOS-style rubber-banding resistance to
CupertinoSheetRoute/showCupertinoSheetwhen dragging is disabled (enableDrag: false)Flutter on the left, SwiftUI on the right
output.mp4
Flutter example
SwiftUI example
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2