Skip to content

[material_ui] Remove no-shuffle from progress indicator test - #12505

Open
ValentinVignal wants to merge 1 commit into
flutter:mainfrom
ValentinVignal:material_ui/test/remove-no-shuffle-from-progress-indicator-test
Open

[material_ui] Remove no-shuffle from progress indicator test#12505
ValentinVignal wants to merge 1 commit into
flutter:mainfrom
ValentinVignal:material_ui/test/remove-no-shuffle-from-progress-indicator-test

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#85160

Port of flutter/flutter#186655

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 19, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'no-shuffle' tag and its associated explanatory comment from the progress_indicator_test.dart file, allowing the test suite to run with randomized ordering. There are no review comments, and I have no feedback to provide.

@dkwingsmt
dkwingsmt self-requested a review August 19, 2026 18:33

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . This doesn't need a pending changelog file since it only affects a test. There was a test failure but it was a timeout, I've rerun it.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2026
@auto-submit

auto-submit Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12505, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants