[google_sign_in] Increase iOS coverage tests by victogomez-cs · Pull Request #12484 · flutter/packages

victogomez-cs · 2026-08-17T16:22:05Z

Adds native unit tests for previously untested paths in FLTGoogleSignInPlugin.m before the Objective-C → Swift migration. Production code is unchanged.

This is a tests-only change, so it does not bump the package version or CHANGELOG.

Native unit tests go from 21 tests / 6 suites to 31 tests / 11 suites.

New test cases

urlHandling (iOS / Mac Catalyst only) — these APIs do not exist on macOS (handleOpenURLs: is the macOS path):

applicationOpenURL — application:openURL:options: forwards the URL to GID and returns true
applicationOpenURLReturnsHandleResult — same path returns false when GID does
sceneOpenURLContexts — scene:openURLContexts: forwards the URL from a UIOpenURLContext stand-in

errorMapping:

mapsRemainingGIDSignInErrorCodes (parameterized):
- GIDSignInError.keychain → FSIGoogleSignInErrorCode.keychainError
- GIDSignInError.EMM → FSIGoogleSignInErrorCode.eemError
- GIDSignInError.unknown → FSIGoogleSignInErrorCode.unknown
- unrecognized SDK code (12345) → FSIGoogleSignInErrorCode.unknown
sanitizesComplexUserInfoInFlutterError — FSISanitizedUserInfo keeps strings/numbers/URLs/arrays/dicts/nested errors and stringifies unsupported types (e.g. Date)

disconnect:

disconnectReturnsFlutterErrorOnFailure — a GID disconnect failure is returned as a Flutter error with domain/code and userInfo

userData:

signInWithoutProfileImageOmitsPhotoUrl — a user with no profile photo gets photoUrl == nil and still maps displayName

topViewController (iOS / Mac Catalyst only) — macOS presents with NSWindow, not a UIViewController hierarchy:

usesNavigationControllerVisibleController — presents from the nav stack’s top VC
usesTabBarControllerSelectedController — presents from the selected tab VC
usesPresentedViewController — presents from a presented VC

Also records URLs passed to TestSignIn.handle(_:) so the URL-handling cases can assert the fake was called.

First part of Swift migration to backfill code coverage for flutter/flutter#119103

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

google-cla · 2026-08-17T16:22:29Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request adds a comprehensive suite of Swift unit tests for the iOS Google Sign-In plugin, covering URL handling, error mapping, disconnect scenarios, user data parsing, and top view controller resolution. The review feedback suggests passing nil instead of a scene instance in the sceneOpenURLContexts test to prevent potential test failures in headless CI environments where connected scenes may be empty.

gemini-code-assist · 2026-08-17T16:23:20Z

+      @Test func sceneOpenURLContexts() throws {
+        let (plugin, fakeSignIn) = createTestPlugin()
+        let url = URL(string: "com.googleusercontent.apps.test:/oauthredirect")!
+        let scene = try #require(UIApplication.shared.connectedScenes.first)
+        let fakeContext = FakeOpenURLContext(url: url)
+
+        plugin.perform(
+          NSSelectorFromString("scene:openURLContexts:"),
+          with: scene,
+          with: NSSet(object: fakeContext))
+
+        #expect(fakeSignIn.handledURLs == [url])
+      }


In headless unit test environments (such as CI runners), UIApplication.shared.connectedScenes can be empty, which causes try #require(UIApplication.shared.connectedScenes.first) to throw and fail the test. Since the scene parameter is completely unused in the plugin's implementation of scene:openURLContexts:, we can pass nil instead and make the test more robust and independent of the application's scene state.

@Test func sceneOpenURLContexts() { let (plugin, fakeSignIn) = createTestPlugin() let url = URL(string: "com.googleusercontent.apps.test:/oauthredirect")! let fakeContext = FakeOpenURLContext(url: url) plugin.perform( NSSelectorFromString("scene:openURLContexts:"), with: nil, with: NSSet(object: fakeContext)) #expect(fakeSignIn.handledURLs == [url]) }

please address gemini comments. It will make review easier.

Add URL handling, error mapping, disconnect, and topViewController cases so FLTGoogleSignInPlugin.m is covered before the Obj-C to Swift migration.

allowSignInPermissions looked up the system permission alert's confirmation button by the literal title "Continue", so testSignInPopUp failed on any simulator whose language is not English; the button is titled in the simulator's language (for example "Continuar" in Spanish). Tap the last of the alert's buttons instead, which is the confirmation button in every localization.

hellohuanlin

Overall looks good. Just some nits.

hellohuanlin · 2026-08-20T18:22:30Z

+        let fakeContext = FakeOpenURLContext(url: url)
+
+        plugin.perform(
+          NSSelectorFromString("scene:openURLContexts:"),


This loses compilation safety. let's avoid using objc hacks

Done! Dropped scene:openURLContexts: because UIOpenURLContext has no public initializer, so the only way to call it was performSelector. Left a TODO to add a typed test after the Obj-C → Swift migration (flutter/flutter#119103).

hellohuanlin · 2026-08-20T18:22:57Z

+      @Test func sceneOpenURLContexts() throws {
+        let (plugin, fakeSignIn) = createTestPlugin()
+        let url = URL(string: "com.googleusercontent.apps.test:/oauthredirect")!
+        let scene = try #require(UIApplication.shared.connectedScenes.first)
+        let fakeContext = FakeOpenURLContext(url: url)
+
+        plugin.perform(
+          NSSelectorFromString("scene:openURLContexts:"),
+          with: scene,
+          with: NSSet(object: fakeContext))
+
+        #expect(fakeSignIn.handledURLs == [url])
+      }


please address gemini comments. It will make review easier.

…swift, with a note to re-add after Obj-C plugin migration to Swift.

hellohuanlin · 2026-08-20T19:58:20Z

+      // the Obj-C plugin is migrated to Swift. The test was dropped because
+      // UIOpenURLContext has no public initializer, so invoking the Obj-C
+      // method required performSelector. See
+      // https://github.com/flutter/flutter/issues/119103


This issue doesn't describe the problem that you are describing above though

You’re right, #119103 is the Swift migration tracker, not this test gap. I linked it because that is the issue we are using for this migration effort, and the typed scene:openURLContexts: test is meant to come back as part of that work. Should I drop the #119103 link from the TODO?

hellohuanlin · 2026-08-20T19:59:16Z

+
+      // TODO(victogomez-cs): Re-add a typed scene:openURLContexts: test after
+      // the Obj-C plugin is migrated to Swift. The test was dropped because
+      // UIOpenURLContext has no public initializer, so invoking the Obj-C


How is the previous objc hack related to UIOpenURLContext's public initializer? Can you add more info?

A typed call needs NSSet<UIOpenURLContext *>. UIKit marks UIOpenURLContext init/new unavailable, so tests cannot build a real context. The old test used performSelector with an NSObject stand-in, which isn’t type-checked. I expanded the TODO to spell that out, still pointing at #119103 as the migration tracker

…d unit test for scene:openURLContexts:. The previous test was removed due to limitations in constructing UIOpenURLContext in Swift.

flutter-dashboard Bot added the CICD Run CI/CD label Aug 17, 2026

github-actions Bot added p: google_sign_in platform-ios platform-macos labels Aug 17, 2026

gemini-code-assist Bot reviewed Aug 17, 2026

View reviewed changes

jmagman added the triage-ios Should be looked at in iOS triage label Aug 17, 2026

[google_sign_in_ios] Expand native unit tests for plugin coverage.

2dccfa6

Add URL handling, error mapping, disconnect, and topViewController cases so FLTGoogleSignInPlugin.m is covered before the Obj-C to Swift migration.

victogomez-cs force-pushed the google_sign_in_ios_coverage_tests branch from e37d0b6 to 2dccfa6 Compare August 17, 2026 16:49

victogomez-cs force-pushed the google_sign_in_ios_coverage_tests branch from 167fe18 to 59fbe19 Compare August 18, 2026 18:28

Merge branch 'main' into google_sign_in_ios_coverage_tests

d59a995

jmagman requested a review from hellohuanlin August 20, 2026 18:06

hellohuanlin reviewed Aug 20, 2026

View reviewed changes

Remove outdated test for scene:openURLContexts: in GoogleSignInTests.…

57346f8

…swift, with a note to re-add after Obj-C plugin migration to Swift.

hellohuanlin reviewed Aug 20, 2026

View reviewed changes

victogomez-cs added 2 commits August 20, 2026 14:20

Update TODO in GoogleSignInTests.swift to clarify the need for a type…

b36f96d

…d unit test for scene:openURLContexts:. The previous test was removed due to limitations in constructing UIOpenURLContext in Swift.

Merge branch 'main' into google_sign_in_ios_coverage_tests

29c5a0c

Navigation Menu

Uh oh!

[google_sign_in] Increase iOS coverage tests - #12484

[google_sign_in] Increase iOS coverage tests#12484
victogomez-cs wants to merge 6 commits into
flutter:mainfrom
victogomez-cs:google_sign_in_ios_coverage_tests

victogomez-cs commented Aug 17, 2026 •

edited

Loading

Uh oh!

google-cla Bot commented Aug 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Aug 17, 2026

Uh oh!

hellohuanlin Aug 20, 2026

Uh oh!

hellohuanlin left a comment

Uh oh!

hellohuanlin Aug 20, 2026

Uh oh!

victogomez-cs Aug 20, 2026

Uh oh!

hellohuanlin Aug 20, 2026

Uh oh!

hellohuanlin Aug 20, 2026

Uh oh!

victogomez-cs Aug 20, 2026

Uh oh!

hellohuanlin Aug 20, 2026

Uh oh!

victogomez-cs Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

victogomez-cs commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New test cases

Pre-Review Checklist

Footnotes

Uh oh!

google-cla Bot commented Aug 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

victogomez-cs commented Aug 17, 2026 •

edited

Loading