Skip to content

Remove unused NetworkRequest.durationDisplay getter and test #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannah-hyj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused NetworkRequest.durationDisplay getter and test #9992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/devtools_app/lib/src/screens/network/network_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,6 @@ abstract class NetworkRequest

String get id;

@visibleForTesting
String get durationDisplay {
final duration = this.duration;
final text = duration != null
? durationText(duration, unit: DurationDisplayUnit.milliseconds)
: 'Pending';
return 'Duration: $text';
}

@override
bool matchesSearchToken(RegExp regExpSearch) {
return uri.caseInsensitiveContains(regExpSearch);
Expand Down
9 changes: 0 additions & 9 deletions packages/devtools_app/test/screens/network/network_model_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,15 +415,6 @@ void main() {
expect(httpWsHandshake.port, 56744);
});

test('durationDisplay returns correct value', () {
expect(httpGet.durationDisplay, 'Duration: 811.7 ms');
expect(httpGetWithError.durationDisplay, 'Duration: 2029.5 ms');
expect(httpPost.durationDisplay, 'Duration: 1508.0 ms');
expect(httpPut.durationDisplay, 'Duration: 1325.8 ms');
expect(httpPatch.durationDisplay, 'Duration: 1243.7 ms');
expect(httpWsHandshake.durationDisplay, 'Duration: 41.4 ms');
});

test('isValid returns correct value', () {
expect(httpGet.isValid, isTrue);
expect(httpGetWithError.isValid, isTrue);
Expand Down
Loading