Support brightness override in a11y page by hannah-hyj · Pull Request #9898 · flutter/devtools

hannah-hyj · 2026-07-16T20:41:09Z

tracking issue: #9893

Screen.Recording.2026-07-16.at.13.41.32.mov

the ext.flutter.brightnessOverride service extension and VM service support to Flutter was added a while ago in PR #59571

Pre-launch Checklist

General checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read the Flutter Style Guide recently, and have followed its advice.
I signed the CLA.
I updated/added relevant documentation (doc comments with ///).

Issues checklist

I listed at least one issue that this PR fixes in the description above.
I listed at least one issue which has the contributions-welcome or good-first-issue label.
I did not list at least one issue with the contributions-welcome or good-first-issue label. I understand this means my PR might take longer to be reviewed.

Tests checklist

I added new tests to check the change I am making...
OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

I did not use any AI tooling in creating this PR.
OR I did use AI tooling, and...
- I read the AI contributions guidelines and agree to follow them.
- I reviewed all AI-generated code before opening this PR.
- I understand and am able to discuss the code in this PR.
- I have verifed the accuracy of any AI-generated text included in the PR description.
- I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

This PR does not change the DevTools UI or behavior and...
- I added the release-notes-not-required label or left a comment requesting the label be added.
OR this PR does change the DevTools UI or behavior and...
- I added an entry to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.
- I included before/after screenshots and/or a GIF demo of the new UI to my PR description.
- I ran the DevTools app locally to manually verify my changes.

If you need help, consider asking for help on Discord.

1

gemini-code-assist

Code Review

This pull request implements the VM service extension integration for overriding brightness in the accessibility controls. It defines the brightnessMode service extension, updates the AccessibilityController to listen to device-side brightness changes, and sends updates back to the VM service when changed via the DevTools UI. Additionally, it adds corresponding analytics constants and comprehensive tests. The reviewer raised a concern regarding potential feedback loops and redundant VM service calls when brightness changes originate from the device itself, suggesting a boolean guard to prevent unnecessary updates.

Update overrides_pane.dart Update accessibility_controller.dart tests Update service_extensions.dart

kenzieschmoll

It looks like this PR is missing the UI code to add the dropdown. Can you include that in this PR?

kenzieschmoll · 2026-07-17T15:50:04Z

+    final state = serviceConnection.serviceManager.serviceExtensionManager
+        .getServiceExtensionState(extensions.brightnessMode.extension);
+
+    void updateFromDeviceState(ServiceExtensionState s) {


nit: rename s to 'state'.

kenzieschmoll · 2026-07-17T15:52:22Z

+      if (brightness.value != newBrightness) {
+        brightness.value = newBrightness;
+      }


you can just call brightness.value = newBrightness directly. The value notifier will return early and not notify if the values are the same.

Suggested change

if (brightness.value != newBrightness) {

brightness.value = newBrightness;

}

brightness.value = newBrightness;

kenzieschmoll · 2026-07-17T15:56:42Z

+/// Service extension description for overriding brightness in accessibility controls.
+final brightnessMode = ServiceExtensionDescription<String>.from(
+  extensions.brightnessMode,
+  title: 'Override brightness',


nit: capital 'B' to match other service extension titles

Suggested change

title: 'Override brightness',

title: 'Override Brightness',

kenzieschmoll · 2026-07-17T15:58:46Z

+        await pumpAccessibilityScreen(tester);
+        await tester.pumpAndSettle();
+
+        expect(controller.brightness.value, BrightnessOverride.system);


This test isn't actually testing the accessibility screen UI so it doesn't need to be a widget test. Can you make a new test file accessibility_controller_test.dart that has unit tests to verify this behavior instead?

elliette · 2026-07-17T17:18:28Z

+    final paramValue = switch (value) {
+      BrightnessOverride.light => 'Brightness.light',
+      BrightnessOverride.dark => 'Brightness.dark',
+      BrightnessOverride.system => '',
+    };


Consider final paramValue = value.name instead. This will evaluate to "light", "dark", or "system". I think using "system" instead of empty string will be make for a more understandable API.

hannah-hyj · 2026-07-17T18:15:28Z

@kenzieschmoll The UI code was merged in #9892, so this PR is just to add functions

Update accessibility_controller.dart

1faa314

1

hannah-hyj requested a review from elliette July 16, 2026 20:41

hannah-hyj requested review from a team and kenzieschmoll as code owners July 16, 2026 20:41

hannah-hyj requested review from bkonyi and removed request for a team July 16, 2026 20:41

gemini-code-assist Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread packages/devtools_app/lib/src/screens/accessibility/accessibility_controller.dart

hannah-hyj added the release-notes-not-required label Jul 16, 2026

1

cd275cb

Update overrides_pane.dart Update accessibility_controller.dart tests Update service_extensions.dart

hannah-hyj force-pushed the a11y_brightness branch from 32aec8c to cd275cb Compare July 16, 2026 20:55

kenzieschmoll reviewed Jul 17, 2026

View reviewed changes

elliette reviewed Jul 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support brightness override in a11y page #9898

Support brightness override in a11y page #9898
hannah-hyj wants to merge 2 commits into
flutter:masterfrom
hannah-hyj:a11y_brightness

hannah-hyj commented Jul 16, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

kenzieschmoll left a comment

Uh oh!

kenzieschmoll Jul 17, 2026

Uh oh!

kenzieschmoll Jul 17, 2026

Uh oh!

kenzieschmoll Jul 17, 2026

Uh oh!

kenzieschmoll Jul 17, 2026

Uh oh!

elliette Jul 17, 2026

Uh oh!

hannah-hyj commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hannah-hyj commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

General checklist

Issues checklist

Tests checklist

AI-tooling checklist

Feature-change checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

kenzieschmoll left a comment

Choose a reason for hiding this comment

Uh oh!

kenzieschmoll Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

kenzieschmoll Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

kenzieschmoll Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

kenzieschmoll Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

elliette Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

hannah-hyj commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hannah-hyj commented Jul 16, 2026 •

edited

Loading