Skip to content

Fix inverted HttpOnly and Secure icons in the network Cookies tab - #10053

Draft
hkarmoush wants to merge 2 commits into
flutter:masterfrom
hkarmoush:fix-cookie-flag-icons
Draft

hkarmoush wants to merge 2 commits into
flutter:masterfrom
hkarmoush:fix-cookie-flag-icons

Conversation

@hkarmoush

Copy link
Copy Markdown
Contributor

No issue for this one, I noticed it while working on #10052.

The HttpOnly and Secure columns in the network Cookies tab were inverted: _buildIconCell(!cookie.httpOnly ? Icons.check : Icons.close) shows a check mark when the cookie is not HttpOnly, and the same for Secure. This has been there since the network page was first added (#1508). Dropping the ! fixes both.

Added a widget test with an HttpOnly, non-Secure cookie that checks the two icons. It fails before the change and passes after.

Before/after screenshots to come.

Pre-launch Checklist

General checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).

Issues checklist

Tests checklist

  • I added new tests to check the change I am making...
  • OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

  • I did not use any AI tooling in creating this PR.
  • OR I did use AI tooling, and...
    • I read the AI contributions guidelines and agree to follow them.
    • I reviewed all AI-generated code before opening this PR.
    • I understand and am able to discuss the code in this PR.
    • I have verifed the accuracy of any AI-generated text included in the PR description.
    • I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

  • This PR does not change the DevTools UI or behavior and...
    • I added the release-notes-not-required label or left a comment requesting the label be added.
  • OR this PR does change the DevTools UI or behavior and...
    • I added an entry to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.
    • I included before/after screenshots and/or a GIF demo of the new UI to my PR description.
    • I ran the DevTools app locally to manually verify my changes.

build.yaml badge

If you need help, consider asking for help on Discord.

The HttpOnly and Secure columns showed a check mark when the flag was
not set, and a cross when it was.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant