Skip to content

feat: export RuleConfig and RuleConfigPatch right in dart_skills_lint.dart#182

Merged
reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:feat/export-rule-config-patch-2026-07-16
Jul 16, 2026
Merged

feat: export RuleConfig and RuleConfigPatch right in dart_skills_lint.dart#182
reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:feat/export-rule-config-patch-2026-07-16

Conversation

@reidbaker-agent

Copy link
Copy Markdown
Contributor

Exposes src/models/rule_config.dart right across the public library entrypoint (lib/dart_skills_lint.dart) so external downstream consumers right can instantiate RuleConfig and RuleConfigPatch directly when migrating off deprecated resolvedRules arguments onto resolvedRuleConfigs without requiring implementation imports.

  • Added export 'src/models/rule_config.dart'; directly across lib/dart_skills_lint.dart.
  • Cleaned up internal implementation imports inside test/api_defaults_test.dart and test/rule_config_test.dart to verify clean public class resolution.
  • Verified zero static analysis warnings (dart analyze --fatal-infos .) and cleanly passed all 207 unit tests.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exports the 'rule_config.dart' model from the main 'dart_skills_lint.dart' library, allowing it to be accessed publicly. Consequently, direct internal imports of 'rule_config.dart' in 'api_defaults_test.dart' and 'rule_config_test.dart' have been removed in favor of importing the main package. There are no review comments, and I have no additional feedback to provide.

@reidbaker
reidbaker merged commit 05e5a45 into flutter:main Jul 16, 2026
14 checks passed
@reidbaker
reidbaker deleted the feat/export-rule-config-patch-2026-07-16 branch July 16, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants