feat: add specialized review, documentation, and CLI skills plus known adopters resource#181
Conversation
…n adopters resource
…ion/resources/known_adopters.md
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds several documentation files and skill guides, including API design principles, code documentation standards for Dart, Python, and TypeScript, Unix CLI best practices, and a list of adopters for the dart_skills_lint tool. The review identified an inaccuracy in the description of an awk command within the Unix CLI best practices guide, which has been addressed with a suggestion to clarify that the command prints unique lines rather than duplicates.
| ```bash | ||
| ls -l | awk '{print $1, $3}' | ||
| ``` | ||
| * Find and print duplicate lines in a file without sorting them first: |
There was a problem hiding this comment.
The description for the awk command on line 120 is incorrect. The command awk '!seen[$0]++' prints the first occurrence of each unique line, effectively removing duplicates while preserving order. It does not print the duplicate lines as the description claims.
To print only the duplicate lines (i.e., the second and subsequent occurrences), the command would be awk 'seen[$0]++' filename.txt.
I suggest updating the description to accurately reflect what the command does.
| * Find and print duplicate lines in a file without sorting them first: | |
| * Find and print unique lines in a file (first occurrence of each line), preserving order: |
2 participants
feat: Add Specialized Review, Documentation, and CLI Skills
Context & Goal
This PR augments our core agent skillset (
reidbaker-agent) with specialized instruction profiles covering canonical API reviews, structured multi-language code documentation, precise test review execution, and reliable UNIX CLI best practices. Additionally, it provides the updated known adopters directory withindart-skills-lint-integration.Source Repository: All expert reference skills adapted in this PR (
api-review,code-documentation,unix-cli-best-practices, plus reference refinements) originate from gspencergoog/skills.Key Improvements & Added Skills
api-review: Comprehensive guidelines and canonical interface specifications (canonical_api_design.md) for evaluating and architecting robust APIs.code-documentation: Idiomatic documentation conventions and structural guidelines covering Dart, Python, and TypeScript (dart.md,python.md,typescript.md).code-review/references/reviewing_tests.md: Specialized verification checklist guaranteeing test structure, assertions, and isolation adhere to project testing standards during review workflows.unix-cli-best-practices: Best practices guide (SKILL.md) covering robust terminal operations, flag structures, and command-line execution conventions.known_adopters.md: Refined adopter index tracking projects employingdart_skills_lintwithindart-skills-lint-integration/resources/.Verification
dart_skills_lintvalidation across all newly authored skills (.agents/agents/reidbaker-agent/skills/anddart-skills-lint-integration). All skills verified (Skill is valid.).dart format .,dart analyze --fatal-infos).