Repository navigation
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
force-pushed
the
fix/records-batch-cleanup
branch
from
October 22, 2026 17:25
4a146a0 to
270c8b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful heap benchmark batch left freed pointers in
roots. If a later batch failed before replacing every entry, cleanup could destroy those pointers again. Clear each entry after destruction and add a regression test that injects failure at the first, middle, and last record of a later batch.Clarify that the large-object threshold applies only to arena-aware owned SDS payloads larger than 1 KiB. Payloads up to and including 1 KiB use pooled size classes regardless of the threshold; the existing size-class and
cfl_sds_alloc()capacity descriptions are preserved.Validation:
BUILD_DIR=/tmp/cfl-feedback-verify scripts/agent-verify.sh: all 35 tests passed; whitespace checks passed.valgrind --quiet --leak-check=full --show-leak-kinds=all --errors-for-leak-kinds=all --error-exitcode=1 /tmp/cfl-feedback-verify/tests/cfl-test-benchmark_records: passed without errors or leaks.8 3 owned 1.Only benchmark behavior, its test registration, and documentation change. No library implementation, API, ABI, or allocator behavior changes; consumers do not need an upgrade for this fix. Cross-platform and downstream checks were not run locally and remain CI coverage.