Repository navigation
Never let PHP-FPM guess the script to run - #72
Merged
Merged
Conversation
cgi.fix_pathinfo = 0 makes PHP-FPM run exactly the script named in SCRIPT_FILENAME. With the default of 1, it walked back a path like /upload.phar/x.php until it found an existing file and ran that one, uploaded files included. security.limit_extensions = .php restricts PHP-FPM to .php files. The default also allows .phar, which is not on the upload blacklist of Flow. The status path used by the FPM exporter is answered before that check and keeps working.
Member
Author
|
Defense in depth for the unauthenticated upload in Neos/Flow (GHSA-7wrr-qcrp-4hhf): with PHP-FPM's defaults, a request like
Tested with
Requires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgi.fix_pathinfo = 0 makes PHP-FPM run exactly the script named in SCRIPT_FILENAME. With the default of 1, it walked back a path like /upload.phar/x.php until it found an existing file and ran that one, uploaded files included.
security.limit_extensions = .php restricts PHP-FPM to .php files. The default also allows .phar, which is not on the upload blacklist of Flow. The status path used by the FPM exporter is answered before that check and keeps working.