Skip to content

perf: reduce arb pickle size by ~50% #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deftasparagusanaconda wants to merge 4 commits into
base: main
Choose a base branch
from
Open

perf: reduce arb pickle size by ~50% #447

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4339714
perf: reduce arb pickle size by ~50%
deftasparagusanaconda Nov 2, 2026
58f028f
fix: arb supports pickling protocols 0 and 1
deftasparagusanaconda Nov 3, 2026
fa18c77
fix: explicit big-endian int unpacking
deftasparagusanaconda Nov 3, 2026
337ffc0
perf(pickle): protocols ≥2 pickle ints natively
deftasparagusanaconda Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 31 additions & 18 deletions src/flint/types/arb.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,13 @@ cimport cython

ctx = thectx


def _arb_from_pickle(mid, rad):
if isinstance(mid, tuple):
mid = tuple(int(x, 16) for x in mid)
mid = tuple(int.from_bytes(x, 'big', signed=True) for x in mid)
if isinstance(rad, tuple):
rad = tuple(int(x, 16) for x in rad)
rad = tuple(int.from_bytes(x, 'big', signed=True) for x in rad)
return arb(mid, rad)


# cdef _str_trunc(s, trunc=0):
# if trunc > 0 and len(s) > 3 * trunc:
# left = right = trunc
Expand Down Expand Up @@ -415,22 +413,37 @@ cdef class arb(flint_scalar):
arf_set_mag(rad.val, arb_radref(self.val))
return (mid, rad)

def __reduce__(self):
# Hex avoids the decimal digit limit in text pickle protocols.
def __reduce_ex__(self, protocol: int):
mid, rad = self._to_arfs()
if mid.is_finite():
mid = tuple(hex(x) for x in mid.man_exp())
elif mid.is_nan():
mid = "nan"
elif mid.is_pos_inf():
mid = "inf"
else:
mid = "-inf"
if rad.is_finite():
rad = tuple(hex(x) for x in rad.man_exp())

if protocol < 2: # protocols 0 and 1 pickle ints inefficiently

@oscarbenjamin oscarbenjamin Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't overcomplicate things. It doesn't matter if protocols 0 and 1 are inefficient.

@deftasparagusanaconda deftasparagusanaconda Nov 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall i remove the comment?

if mid.is_finite():
mid = tuple(int(x).to_bytes((x.bit_length()+8)//8, 'big', signed=True) for x in mid.man_exp())
elif mid.is_nan():
mid = "nan"
elif mid.is_pos_inf():
mid = "inf"
else:
mid = "-inf"
if rad.is_finite():
rad = tuple(int(x).to_bytes((x.bit_length()+8)//8, 'big', signed=True) for x in rad.man_exp())
else:
rad = "inf"
return (_arb_from_pickle, (mid, rad))
else:
rad = "inf"
return (_arb_from_pickle, (mid, rad))
if mid.is_finite():
mid = tuple(map(int, mid.man_exp()))
elif mid.is_nan():
mid = "nan"
elif mid.is_pos_inf():
mid = "inf"
else:
mid = "-inf"
if rad.is_finite():
rad = tuple(map(int, rad.man_exp()))
else:
rad = "inf"
return (arb, (mid, rad))

def repr(self):
mid, rad = self._to_arfs()
Expand Down