Repository navigation
feat: Linux packages, notification sound settings, simpler smoke; rel… - #6
Merged
Merged
Conversation
…ease 2.0.1 Linux - electron-builder: AppImage + deb (x64), build:linux scripts, CI leg on ubuntu-latest with xvfb, release expects the two new files. - smoke harness knows the Linux binary and userData locations. Sounds - Settings: turn the notification sound off, and choose between nine bundled sounds (all under a second, level-matched, CC0 from Kenney) with a preview button. Off silences only the sound, never the notification. - New settings soundEnabled / notificationSound, validated in main against the bundled list; main decides at play time and sends the chosen file to the renderer. - notification.mp3 is replaced by sounds/*.ogg. Tests hold every offered sound to an existing, short file. Cleanup - Remove baselines/ and everything that only existed to read it: the parity, responsive-matrix, offline-routes, upgrade and second-instance checks, the baseline capture tooling, their tests and CI steps. - Rewrite the packaged smoke around three launches: fresh install, v1.2.1 upgrade (nothing lost, one backup) and a newer database (refused, untouched). Each also checks Home, Settings and a decoded sound. The app side (src/main/smoke.ts) drops from ~1080 to ~300 lines. Version bumped to 2.0.1. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The copied Kenney license carried CR characters and padded indentation, which the whitespace check in verify.yml rejects. Rewritten as a short plain-text notice. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
On a cold first launch on a CI runner the audio element was still loading metadata when the fixed wait ended (duration 0, no error), which read as an undecodable file. Poll until it has a duration or an error, bounded by the render timeout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ease 2.0.1
Linux
Sounds
Cleanup
Version bumped to 2.0.1.