Repository navigation
feat(account): phone sign-in, code verification and the account screen - #75
Merged
Merged
Conversation
- Sign in and sign up share one phone-first screen: searchable country picker, inline errors, enabled social providers, terms and privacy links. - One code screen handles sign-in, sign-up, adding a phone and confirming account deletion: six boxes with SMS autofill, auto-submit, inline mismatch error and a resend timer. - Signing in from checkout returns straight to the checkout. - New account screen: profile header, add-phone prompt, active order, orders, offers, saved places, payment methods, notifications with an unread badge, language and appearance pickers, sign out and delete. - Remove the screens these replace. - Web: shim the native Google Sign-In package, which crashed the web bundle, and hide the Google button there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #74. Redesigns sign-in, sign-up, code verification and the account screen to match the prototype.
Sign in and sign up
defaultCountryfrom the storefront config, then the device region.termsUrl/privacyUrlare configured.Code verification
Account screen
Other
Login,CreateAccountandProfileresolve to the new screens through the screen registry. The old login, verify, add-phone and profile screens are removed.AuthandAccountstrings added in English, Mongolian and Ukrainian.Checks
yarn jest: 192 passing, including new tests for the redirect hand-off and the Google Sign-In shim.yarn typecheck:strictandyarn lint:strictpass with no errors.Known issue (not from this PR)
On web, choosing Light while the device is in dark mode (or the reverse) leaves themed colours empty. The theme CSS only defines its variables inside
prefers-color-schememedia queries. The appearance picker makes this easier to hit, so it's being fixed separately in the theme CSS post-processing.