Small optimizations#27
Draft
KA-ROM wants to merge 17 commits into
Draft
Conversation
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six small, self-contained optimizations on the
engine_*hot path, each removing a per-request memory allocation or a redundant lookup. No behavior changes.What this removes from the hot path
is_hop_by_hop_headerused to allocate a lowercasedStringfor every comparison; it now matchesHeaderNameconstants directly, so the allocation is gone.Gauge/Counterhandles were resolved viaget_or_createon every request; they're now resolved once and cached onProxyHttp.scc::HashMap<String, Counter>, so the warm path is a plain&strread instead of a metric-family lookup plus allocation.connection_info()called once instead of 5×: bound a single time per request and reused.headers_mut().append(...)skips reparsing each header name through the builder.HeaderName::from_str. Backend header names are already valid, so the parse and its error path were dead weight.