FDS Source : Refactor complex geometry module.#16339
Merged
marcosvanella merged 21 commits intoJun 16, 2026
Merged
Conversation
marcosvanella
commented
Jun 16, 2026
marcosvanella
commented
Contributor
- New COMPLEX_GEOMETRY_GRID module holding all cut-cell grid-building code and data.
- COMPLEX_GEOMETRY module now handles shapes generation and low-level computational-geometry primitives.
- Split the monolithic SET_CUTCELLS_3D into stages. Promoted contained internal routines to module level.
- Ported master's refinement-interface cut-cell blocking into the new code sequence.
- Refactor is behavior-preserving (organization/scope only, not numerics).
- WIP: Added GCELL type and low-level primitives for cell linking/rebuild.
Resolved conflicts:
- pres.f90: keep refactor's GLOBMAT_SOLVER imports + add CC_IDCC (needed by
master's REG_INTERP_WALL_DISTANCES); IPARM stays locally declared,
NNZ_ROW_H dropped (unused).
- geom.f90: kept refactored version and re-applied master's self-contained
source fixes into the new module structure:
* 2424a14 IN_SPHERE/CYLINDER/CONE/OBB_PT + PUBLIC exports
* aef8a7b + b0a56bd MIN_VOL_FACTOR -> 2.5E-3
* b521ec2 UGLMAT coupling (CUT_CELL_FACE_ARRAYS_CLEANUP CCVAR
invalidation + CELL_DEALLOC guard)
NOT YET PORTED (follow-up): blocking-in-refinement cluster
3831e63, c10badc, 1a9648b, 9ddda15. These are woven into
master's monolithic SET_CUTCELLS_3D via host association and must be
re-threaded into the refactored CC_GRID_* pipeline.
Builds clean: ompi_gnu_osx_db (full debug flags).
…refactored geom.f90.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.