Repository navigation
Fix installed migration scaffold selection for 26.10.5 - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed wheels currently resolve
alembic.inirelative tosite-packages, soflycanon migratemisses the reviewed scaffold in the operator's working directory. Select./alembic.iniexplicitly and reject a missing or non-file configuration before migration starts. KeepFLYCANON_DATABASE_URL,upgrade head, wheel contents, migrations, and serve behavior unchanged.Add three regression cases for a wheel-style module location, missing configuration with a valid parent configuration, and a directory named
alembic.ini. Update installation/CLI guidance, document the direct Alembic workaround for retained 26.10.4 installations, and align existing server/SDK version metadata for proposed 26.10.5. No release or tag is created by this PR.The concurrency test module uses a temporary file-backed SQLite database so concurrent AsyncSessions receive independent connections. Two causal controls cover distinct DBAPI identities and rollback isolation. All 31 original concurrency test functions retain identical ASTs; global unit fixtures and production transaction code are unchanged. The OpenAPI snapshot changes only
info.versionto match the release metadata.Validation:
TestKnowledgeRetireServiceConcurrency::test_concurrent_retire_one_winnerandTestKnowledgeVersionConflictServiceConcurrency::test_concurrent_update_one_typed_conflict. The update-history failure also reproduced against the unchanged installed public 26.10.4 package. This test-fixture correction does not qualify PostgreSQL transactions.Independent review preserved all 31 original concurrency-test ASTs and reran all three CLI plus 33 concurrency cases successfully. Current-head hosted CI passes all seven jobs: server units, native integration, Python SDK, Java SDK, lint, advisory type checking, and Docker build smoke. The SDK lockfile is aligned with 26.10.5; no dependency versions changed.
New installed-CLI migration observation and public release artifact/tag verification remain separate. The retained 26.10.4 knowledge environment is unchanged and uses its documented Alembic workaround.