feat(sheet): expose worksheet name and used-range origin on Table - #69
Open
alexiskowalski wants to merge 8 commits into
Open
feat(sheet): expose worksheet name and used-range origin on Table#69alexiskowalski wants to merge 8 commits into
alexiskowalski wants to merge 8 commits into
Conversation
added 8 commits
August 8, 2026 22:54
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
Signed-off-by: f1vwpbleiia7ie <f1vwpbleiia7ie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10 by preserving spreadsheet worksheet identity and used-range origin on
Table.to_document()cropped Excel ranges to a 0-based grid and, for single-sheet workbooks, dropped the sheet name entirely. Callers could not tell that grid[0][0]came fromC3onData Sheet.Changes
sheet_name,source_row, andsource_colonTable(absolute 0-based origin of the used range).sheet_namefor ODS spreadsheet tables when the table has a name.Test plan
C3assertssheet_name == "Data Sheet"andsource_row/col == 2.cargo test --locked formats::sheet