Fix invalid EPUB spine references - #54
Open
Ray0907 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idrefvalues or dangling manifest references as failed chapters.ConvertError::Malformedwhen every declared spine entry is unusable.idrefis absent from the manifest.Root cause
Spine entries were collected through
filter_map, so malformed or unresolved entries weresilently discarded before the parser's failed-chapter accounting. An EPUB containing only a
dangling spine reference therefore returned an empty successful document instead of a malformed
input error.
Validation
cargo test formats::epub::tests::unresolved_spine_itemref_is_malformed -- --exact --nocapturecargo fmt --all --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --lockedNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.