Table pagination - Fixed bug when page size is small#913
Open
AleksandarCila wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes collection table pagination getting stuck when small page sizes are used, such as
pagination: 10.Problem
VirtualTableusedendOffsetboth to detect when the user was near the bottom and to throttle repeatedonEndReachedcallbacks. With the defaultendOffsetof600px, pagination could fail when the table had no scroll area, or when the available scroll distance was smaller than600px.Changes
onEndReachedonce per loadeddata.lengthinstead of requiring the scroll offset to advance byendOffsetpixels.endOffsetbehavior for deciding when the user is near the bottom.Testing
pagination: 10and more than 10 documents.600px.Screenshots
Page size 10 on big screen

Page size 2 on small screen

Closes #912