Skip to content

Feat: quickstart video-analysis sample feature - #1083

Open
sedanah-m wants to merge 6 commits into
masterfrom
feat/video-anaylsis-final
Open

Feat: quickstart video-analysis sample feature#1083
sedanah-m wants to merge 6 commits into
masterfrom
feat/video-anaylsis-final

Conversation

@sedanah-m

Copy link
Copy Markdown
Contributor

@sedanah-m
sedanah-m marked this pull request as ready for review September 2, 2026 17:01
Comment thread ai/ai-samples/src/features/video-anaylsis/index.tsx Fixed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new video analysis feature using the Gemini API, allowing users to upload videos and receive analysis results via standard or streaming responses. The reviewer feedback points out critical issues with invalid model names (gemini-3.5-flash and gemini-3.7-flash) that would cause runtime failures, recommending valid alternatives like gemini-1.5-flash. Additionally, an improvement is suggested to use onload instead of onloadend in the FileReader logic to avoid redundant promise rejections.

Comment thread ai/ai-samples/src/features/video-anaylsis/service.ts Outdated
Comment thread ai/ai-samples/src/features/video-anaylsis/service.ts Outdated
Comment thread ai/ai-samples/src/features/video-anaylsis/service.ts Outdated
sedanah-m and others added 4 commits September 2, 2026 10:04
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@sedanah-m sedanah-m changed the title feat: quickstart video-analysis sample feature Feat: quickstart video-analysis sample feature Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants