feat(messaging): migrate FCM Web quickstart to FID-based APIs - #1080
Open
hozhng wants to merge 1 commit into
Open
feat(messaging): migrate FCM Web quickstart to FID-based APIs#1080hozhng wants to merge 1 commit into
hozhng wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase Cloud Messaging (FCM) Quickstart sample to use the latest Firebase SDK (v12.17.1) and transitions the implementation from legacy registration tokens to the new FID-based (Firebase Installation ID) APIs. Key changes include updating the main application and service worker scripts, revising the HTML UI to display the FID, and updating the README with the FCM HTTP v1 API documentation. The review feedback highlights several critical issues: a version mismatch between the service worker and the main application, potential runtime crashes in environments lacking the Notification API, a UI bug where denied permission errors are hidden, and a typo in the HTML charset attribute.
hozhng
force-pushed
the
feat/fcm-fid-api-migration
branch
7 times, most recently
from
August 18, 2026 19:42
9bfe127 to
f439ad6
Compare
hozhng
marked this pull request as draft
August 18, 2026 20:51
hozhng
marked this pull request as ready for review
August 18, 2026 20:53
Doris-Ge
reviewed
Aug 22, 2026
hozhng
force-pushed
the
feat/fcm-fid-api-migration
branch
3 times, most recently
from
August 25, 2026 17:57
14de063 to
f7f3feb
Compare
Doris-Ge
reviewed
Aug 28, 2026
Doris-Ge
left a comment
Doris-Ge
left a comment
There was a problem hiding this comment.
Could you deploy your latest changes in this PR to https://android-gcm-test-519bd.web.app/?
hozhng
force-pushed
the
feat/fcm-fid-api-migration
branch
from
September 1, 2026 22:18
f7f3feb to
3f12cd8
Compare
Author
done! |
hozhng
force-pushed
the
feat/fcm-fid-api-migration
branch
from
September 2, 2026 21:25
3f12cd8 to
3da73f4
Compare
Doris-Ge
reviewed
Sep 2, 2026
Comment on lines
+127
to
+130
| // TODO(developer): Retrieve a registration token for use with FCM. | ||
| // In many cases once an app has been granted notification permission, | ||
| // it should update its UI reflecting this. | ||
| // Retrieve registration FID for use with FCM. |
There was a problem hiding this comment.
Suggested change
| // TODO(developer): Retrieve a registration token for use with FCM. | |
| // In many cases once an app has been granted notification permission, | |
| // it should update its UI reflecting this. | |
| // Retrieve registration FID for use with FCM. | |
| // TODO(developer): Retrieve Firebase Installation ID (FID) for use with FCM. | |
| // In many cases once an app has been granted notification permission, | |
| // it should update its UI reflecting this. |
| console.log('Error retrieving registration token. ', err); | ||
| showToken('Error retrieving registration token.'); | ||
| function unregisterFromFirebase() { | ||
| // Unregister registration FID. |
There was a problem hiding this comment.
Suggested change
| // Unregister registration FID. | |
| // Unregister FID with FCM. |
hozhng
force-pushed
the
feat/fcm-fid-api-migration
branch
from
September 3, 2026 17:29
d8a8240 to
fe7371d
Compare
- Replace deprecated getToken/deleteToken with register/unregister and onRegistered/onUnregistered callbacks - Update UI elements and terminology from Registration Token to Installation ID (FID) - Upgrade firebase dependency to ^12.17.1 to support FID APIs - Update README documentation and cURL instructions for FCM HTTP v1 API Bug: b/522441204
hozhng
force-pushed
the
feat/fcm-fid-api-migration
branch
from
September 3, 2026 17:40
fe7371d to
3d210d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate Firebase Cloud Messaging (FCM) Web quickstart sample app to use the new FID-based SDK APIs.
Key Changes
getToken/deleteTokenwithregister/unregisterandonRegistered/onUnregisteredcallbacks inmessaging/main.ts.firebaseto^12.17.1.README.mdto reflect FID registration flow and FCM HTTP v1 cURL format.Verification
npm run dev).onRegisteredcallback receiving FID, ForegroundonMessagehandler, andunregisterflow.npm run build).