Repository navigation
feat: migrate legacy UIKit samples to UIScene lifecycle - #1883
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates multiple Firebase example applications (Database, Firestore, InAppMessaging, Installations, and Messaging) to support the UIScene-based lifecycle. It introduces a new SceneDelegate.swift file to each project, configures the UIApplicationSceneManifest in their respective Info.plist files, registers the new scene delegates in the Xcode project files, and removes the unused window property from the AppDelegate classes. There are no review comments to address, and the changes look correct and consistent across all projects.
ncooke3
force-pushed
the
nc.uiscene-migration
branch
from
October 28, 2026 17:05
abc6f18 to
5eb4869
Compare
ncooke3
force-pushed
the
nc.uiscene-migration
branch
from
October 28, 2026 17:07
5eb4869 to
a11eb55
Compare
Member
Author
|
Firestore failure is expected. |
ncooke3
enabled stacked auto-merge (squash)
October 28, 2026 17:25
daymxn
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with the iOS 27 SDK in Xcode 27, UIKit enforces
UIScenelifecycle adoption at launch and terminates apps that still rely on the legacyUIApplicationDelegatewindow lifecycle (SIGTRAPin_UIApplicationEvaluateRuntimeIssueForNoSceneLifecycleAdoption).This PR migrates the five remaining UIKit quickstart targets (
installations,database,firestore,inappmessaging, andmessaging) toUIWindowSceneusing aSceneDelegateand a staticUIApplicationSceneManifestinInfo.plist, preserving backward compatibility with Xcode 26 while unblocking Xcode 27 simulator tests.