Repository navigation
build(deps): update firebase-ios-sdk to 13.1.1 and resolve build configurations - #1880
Conversation
…igurations Update firebase-ios-sdk package dependency across all sample projects to minimumVersion 13.1.1 with upToNextMajorVersion. Also update GoogleSignIn-iOS to 10.1.0 and FirebaseUI-iOS to 16.2.0 where used. Address required build configuration updates for Xcode and Firebase 13: - Fix duplicate GoogleService-Info.plist tasks by moving to Resources phase - Add mock GoogleService-Info.plist to PasswordlessSwiftUI - Correct Info.plist path for AppDistributionExample test targets - Remove obsolete FirebaseDatabaseSwift and FirebaseAuthUI references - Add @mainactor isolation to AuthenticationExampleUITests - Conditionally apply deployment target overrides for Xcode 27+ in scripts/test.sh
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum version of the Firebase iOS SDK to 13.1.1 across various example projects, cleans up project configurations, and transitions the Firestore example from Firebase AuthUI to anonymous authentication. Feedback on these changes highlights three key issues: first, in RestaurantsTableViewController.swift, checking the current user inside the population loop after writing the restaurant document can lead to inconsistent database states; second, the asynchronous signInAnonymously() call lacks error handling; and third, the Xcode version check in scripts/test.sh for version 27 or higher is likely a typo that prevents the block from executing.
Apply swiftformat rules via scripts/style.sh to resolve CI style check failures.
FirebaseRemoteConfig in firebase-ios-sdk 13.1.1 requires a minimum deployment target of watchOS 8.0, whereas ABTestingExample was still configured for watchOS 7.0.
…ereq InstallationsExample.xcodeproj already includes GoogleService-Info.plist in its Resources build phase. Running info_script.rb in CI added a second reference and caused an unexpected duplicate tasks build error.
Xcode 26.2 does not enable default SwiftPM package traits for remote package references in Xcode projects, causing FirebaseFirestore in firebase-ios-sdk 13.1.1 to fail with FIRESTORE_TRAIT_ENABLED undefined. Run the Firestore workflow on macos-26 with Xcode 26.4 where package traits are supported.
…lures Warm up CoreSimulatorService via xcrun simctl before invoking xcodebuild after xcode-select switches, and retry once if xcodebuild fails due to transient simulator discovery issues.
|
I'm going to follow-up with a better Xcode x macOS matrix that hits our minimum (Xcode26.2 x macos15) and also adds Xcode 27 support. Since this is green and focused on GSI/Firebase/Firebase-UI updates, marking ready-for-review. |
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
LGTM after two comments are addressed
Update firebase-ios-sdk package dependency across all sample projects to minimumVersion 13.1.1 with
upToNextMajorVersion.Also update GoogleSignIn-iOS to 10.1.0 and FirebaseUI-iOS to 16.2.0 where used. Address required build configuration updates for Xcode and Firebase 13:
@MainActorisolation to AuthenticationExampleUITests