Skip to content

fix(auth, web): connect Auth emulator after reload when sessionStorage already has the origin - #18690

Merged
SelaseKay merged 2 commits into
mainfrom
auth_18689
Sep 15, 2026
Merged

SelaseKay merged 2 commits into
mainfrom
auth_18689

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

On web, useAuthEmulator skipped connectAuthEmulator when sessionStorage already had the emulator origin from a previous page load. After a full reload the JS Auth instance is new and still points at production, so that skip sent traffic to prod (especially on 127.0.0.1, where plugin init never reconnected).

Skip only when this JS Auth instance is already on the requested origin (emulatorConfig). Also re-apply the persisted origin on 127.0.0.1 / [::1] at plugin init, not just localhost.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…e already has the origin

Skip connectAuthEmulator only when this JS Auth instance is already on the requested origin. Matching sessionStorage is not enough after a full page reload, especially on 127.0.0.1 where the early reconnect used to be skipped.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay merged commit 3740a2d into main Sep 15, 2026
37 checks passed
@SelaseKay
SelaseKay deleted the auth_18689 branch September 15, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FirebaseAuth]: Reopen: Emulator in development doesn't work after logged in / Loading use from session storage..

3 participants