Skip to content

fix(storage,windows): Windows list()/listAll() now throw unimplemented instead of returning misleading empty results #18449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 1 commit into from
Jul 20, 2026
+28 −10
Merged

fix(storage,windows): Windows list()/listAll() now throw unimplemented instead of returning misleading empty results #18449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions packages/firebase_storage/firebase_storage/windows/firebase_storage_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,22 +470,18 @@ void FirebaseStoragePlugin::ReferenceList(
const InternalStorageReference& reference,
const InternalListOptions& options,
std::function<void(ErrorOr<InternalListResult> reply)> result) {
// C++ doesn't support list yet
flutter::EncodableList items = flutter::EncodableList();
flutter::EncodableList prefixs = flutter::EncodableList();
InternalListResult pigeon_result = InternalListResult(items, prefixs);
result(pigeon_result);
result(FlutterError(
"unimplemented",
"Listing files is not supported by the Firebase C++ SDK on Windows."));
}

void FirebaseStoragePlugin::ReferenceListAll(
const InternalStorageFirebaseApp& app,
const InternalStorageReference& reference,
std::function<void(ErrorOr<InternalListResult> reply)> result) {
// C++ doesn't support listAll yet
flutter::EncodableList items = flutter::EncodableList();
flutter::EncodableList prefixs = flutter::EncodableList();
InternalListResult pigeon_result = InternalListResult(items, prefixs);
result(pigeon_result);
result(FlutterError(
"unimplemented",
"Listing files is not supported by the Firebase C++ SDK on Windows."));
}

void FirebaseStoragePlugin::ReferenceGetData(
Expand Down
22 changes: 22 additions & 0 deletions tests/integration_test/firebase_storage/reference_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,28 @@ void setupReferenceTests() {
skip: defaultTargetPlatform == TargetPlatform.windows,
);

test(
'list operations report that they are unsupported on Windows',
() async {
final Reference ref = storage.ref('flutter-tests/list');
final unsupportedError = isA<FirebaseException>()
.having((error) => error.code, 'code', 'unimplemented')
.having(
(error) => error.message,
'message',
'Listing files is not supported by the Firebase C++ SDK on '
'Windows.',
);

await expectLater(
ref.list(const ListOptions(maxResults: 25)),
throwsA(unsupportedError),
);
await expectLater(ref.listAll(), throwsA(unsupportedError));
},
skip: defaultTargetPlatform != TargetPlatform.windows,
);

test(
'listAll',
() async {
Expand Down
Loading