Repository navigation
build(deps): dependency updates 20261113 - #1542
russellwheatley wants to merge 8 commits into
Conversation
Bumps the angular group with 1 update: [ng-packagr](https://github.com/ng-packagr/ng-packagr). Updates `ng-packagr` from 22.1.1 to 22.2.5 - [Release notes](https://github.com/ng-packagr/ng-packagr/releases) - [Changelog](https://github.com/ng-packagr/ng-packagr/blob/22.2.5/CHANGELOG.md) - [Commits](ng-packagr/ng-packagr@22.1.1...22.2.5) --- updated-dependencies: - dependency-name: ng-packagr dependency-version: 22.2.5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: angular ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.10 to 5.0.5. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the github-actions-minor-patch group with 1 update: [pnpm/action-setup](https://github.com/pnpm/action-setup). Updates `pnpm/action-setup` from 6.1.0 to 6.1.1 - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@ea17c68...73e4699) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….0.5' into build/dependency-updates-20261113
…274d63f6fb' into build/dependency-updates-20261113 # Conflicts: # pnpm-lock.yaml
There was a problem hiding this comment.
Code Review
This pull request updates workspace dependencies in pnpm-workspace.yaml and pnpm-lock.yaml, notably upgrading ng-packagr to ^22.2.5 and vitest to ^5.0.5. Feedback on the changes highlights a major version mismatch introduced by upgrading vitest to 5.0.5 while leaving @vitest/coverage-v8 and @vitest/ui at version 4.1.10 in the catalog, which could lead to runtime errors or compatibility issues.
| typescript: ^6.0.3 | ||
| vite: ^8.2.4 | ||
| vitest: ^4.1.10 | ||
| vitest: ^5.0.5 |
There was a problem hiding this comment.
Upgrading vitest to 5.0.5 while keeping @vitest/coverage-v8 and @vitest/ui at 4.1.10 in the catalog introduces a major version mismatch. This is highly likely to cause runtime errors, API compatibility issues, or failures in coverage reporting and the Vitest UI, as Vitest v5 contains breaking changes and a different runner architecture compared to v4. Please update @vitest/coverage-v8 and @vitest/ui to ^5.0.5 in the catalog as well to ensure version alignment across all Vitest packages.
References
- The workspace uses pnpm catalogs to ensure dependency version alignment. Keeping mismatched major versions of Vitest packages violates the alignment principle. (link)
Bumps [next](https://github.com/vercel/next.js) from 16.4.1 to 16.4.5. - [Release notes](https://github.com/vercel/next.js/releases) - [Commits](vercel/next.js@v16.4.1...v16.4.5) --- updated-dependencies: - dependency-name: next dependency-version: 16.4.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…4.5' into build/dependency-updates-20261113-wt # Conflicts: # pnpm-lock.yaml
Combines open Dependabot PRs onto one branch.
Included
github-actions-minor-patchgroup (chore(deps): bump pnpm/action-setup from 6.1.0 to 6.1.1 in the github-actions-minor-patch group across 1 directory #1538):pnpm/action-setup6.1.0 → 6.1.1vitest4.1.10 → 5.0.5 in the pnpm catalog (chore(deps): bump vitest from 4.1.10 to 5.0.5 #1534). Dev dependency only in every package.angulargroup (chore(deps): bump ng-packagr from 22.1.1 to 22.2.6 in the angular group across 1 directory #1530):ng-packagr22.1.1 → 22.2.5 in the catalog (resolves 22.2.6). Dev dependency only inpackages/angularand the Angular example.next16.4.1 → 16.4.5 in the pnpm catalog (chore(deps): bump next from 16.4.1 to 16.4.5 #1543). Only used byexamples/nextjsandexamples/nextjs-ssr, not by any published package.Merge notes
pnpm-lock.yamlconflicted when merging chore(deps): bump ng-packagr from 22.1.1 to 22.2.6 in the angular group across 1 directory #1530 on top of chore(deps): bump vitest from 4.1.10 to 5.0.5 #1534. Took the branch side and regenerated withpnpm install(pnpm 11.9.0 frompackageManager); a secondpnpm installleft the lockfile unchanged.pnpm-lock.yamlconflicted again when adding chore(deps): bump next from 16.4.1 to 16.4.5 #1543 (2026-11-18). Same approach: kept the branch side, regenerated withpnpm install, second install was a no-op.@vitest/coverage-v8and@vitest/uistay at 4.1.10 next to vitest 5, same as on chore(deps): bump vitest from 4.1.10 to 5.0.5 #1534. Unit tests run fine with it; they can move with the next npm group.pnpm lint:check,pnpm format:check,pnpm build:packagesandpnpm test(327 tests) all pass locally after adding chore(deps): bump next from 16.4.1 to 16.4.5 #1543.main(feat(forms): add a password visibility toggle to sign-in and sign-up forms #1509, docs(skills): split getting-started skill into per-platform references #1545) into the branch, no conflicts.pnpm installtwice leftpnpm-lock.yamlunchanged;pnpm lint:check,pnpm format:check,pnpm build:packagesandpnpm testall pass (including the newpassword-inputtests under vitest 5).Intentionally skipped
npm-minor-patchgroup (52 updates): changesdependenciesin publishedpackages/core,packages/react,packages/angularandpackages/shadcn, and failstestandui-e2e.firebase-jsgroup (firebase,@angular/fire): changespackages/angular/package.jsonranges consumers install against, and failsLint and Format Check,testandui-e2e.Obsoletes