Repository navigation
WIP - #1939
WIP#1939AustinBenoit wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase iOS SDK dependency across multiple integration test Xcode projects, CMake configurations, and Swift Package Manager files to point to a specific git revision instead of version 13.0.1. It also modifies the Apple build script to set the FIREBASE_SOURCE_FIRESTORE environment variable. Feedback suggests scoping this environment variable change specifically to the Firestore testapp to avoid global side effects and unnecessary build time increases for other testapps.
| _run(xcode_patcher_args) | ||
|
|
||
| xcode_path = os.path.join(project_dir, "integration_test.xcodeproj") | ||
| os.environ["FIREBASE_SOURCE_FIRESTORE"] = "1" |
There was a problem hiding this comment.
Mutating os.environ globally inside _build_apple introduces side effects that persist across the execution of the script for all subsequent testapp builds. Additionally, setting FIREBASE_SOURCE_FIRESTORE unconditionally to "1" for all Apple builds might unnecessarily force Firestore to be built from source even for non-Firestore testapps, increasing build times. Consider scoping this environment variable change so it only applies when building the firestore testapp.
| os.environ["FIREBASE_SOURCE_FIRESTORE"] = "1" | |
| if api_config.name == "firestore": | |
| os.environ["FIREBASE_SOURCE_FIRESTORE"] = "1" |
AustinBenoit
added
the
tests-requested: full
github-actions
Bot
added
tests: in-progress
⏳ Integration test in progress...Requested by @AustinBenoit on commit 0bf1bc9 |
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
AustinBenoit
added
tests-requested: full
github-actions
Bot
added
tests: in-progress
WIP