fix(nox): install a self-reference's extras in test_distributions - #625
Merged
Conversation
_collect_test_deps drops test dependencies that point at a package under test, so bfabric's own "bfabric[transfer]" test dependency was dropped whole and tuspy never got installed. Every release so far also shipped bfabric_scripts, whose runtime dependency is bfabric[transfer], so the extra arrived transitively and hid this; a bfabric-only release fails collection with ModuleNotFoundError: No module named 'tusclient'. Keep the extras of such a self-reference and append them to the wheel install (bfabric-1.22.0-py3-none-any.whl[transfer]), which uv and pip both accept.
Member
Author
|
Found in #624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nox -s test_distributionsdropping a package's own test extras, so a bfabric-only release preview no longer fails collection withNo module named 'tusclient'