Resolve a single-version app spec without application_version - #605
Draft
leoschwarz wants to merge 1 commit into
Draft
Resolve a single-version app spec without application_version#605leoschwarz wants to merge 1 commit into
leoschwarz wants to merge 1 commit into
Conversation
…ersion An app spec that defines exactly one version leaves nothing to choose, so a workunit without an application_version parameter now resolves to that version. This is what makes an app that never had the parameter work unchanged. Issue #236 was closed because a default version reduces reproducibility, and that holds for a heuristic among several versions: which one you get changes as the spec grows. With one version the outcome set is {that version, hard error}, never a different version silently -- an explicitly named version is still taken literally, so a single-version spec asked for 9.9.9 resolves to nothing. The residual hole, worth knowing: replacing the one version in place makes a re-run resolve to the new one. That is the same class as editing a named version's commands in place, which already breaks reproducibility today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
application_versionparameter, so an app that never had the parameter works unchanged. An explicitly named version is still taken literally, so a single-version spec asked for an undefined version resolves to nothing rather than running the one it has.AppSpec.for_parameters; the base retargets to main once that merges.